From c552b641b80d15513854357f36191104c5d2ae3c Mon Sep 17 00:00:00 2001 From: Quinlan Jung Date: Wed, 17 Jan 2024 19:56:57 -0800 Subject: [PATCH 1/3] Revert "[1/1][eas-cli] generate eas-update-metadata.json on publish (#2158)" This reverts commit 183fe8712b4fe2da5b67d47790b635a3f080d689. --- packages/eas-cli/src/commands/update/index.ts | 4 ---- packages/eas-cli/src/project/publish.ts | 16 ++-------------- 2 files changed, 2 insertions(+), 18 deletions(-) diff --git a/packages/eas-cli/src/commands/update/index.ts b/packages/eas-cli/src/commands/update/index.ts index 14b570783b..2ae0b223d3 100644 --- a/packages/eas-cli/src/commands/update/index.ts +++ b/packages/eas-cli/src/commands/update/index.ts @@ -29,7 +29,6 @@ import { collectAssetsAsync, defaultPublishPlatforms, filterExportedPlatformsByFlag, - generateEasMetadataAsync, getBranchNameForCommandAsync, getRequestedPlatform, getRuntimeToPlatformMappingFromRuntimeVersions, @@ -469,9 +468,6 @@ export default class UpdatePublish extends EasCommand { throw e; } - if (!skipBundler) { - await generateEasMetadataAsync(distRoot, getUpdateJsonInfosForUpdates(newUpdates)); - } if (jsonFlag) { printJsonOnlyOutput(getUpdateJsonInfosForUpdates(newUpdates)); } else { diff --git a/packages/eas-cli/src/project/publish.ts b/packages/eas-cli/src/project/publish.ts index 0ab8aa476b..0c468749f8 100644 --- a/packages/eas-cli/src/project/publish.ts +++ b/packages/eas-cli/src/project/publish.ts @@ -12,7 +12,6 @@ import nullthrows from 'nullthrows'; import path from 'path'; import promiseLimit from 'promise-limit'; -import { resolveWorkflowAsync } from './workflow'; import { selectBranchOnAppAsync } from '../branch/queries'; import { getDefaultBranchNameAsync } from '../branch/utils'; import { ExpoGraphqlClient } from '../commandUtils/context/contextUtils/createGraphqlClient'; @@ -24,11 +23,7 @@ import Log, { learnMore } from '../log'; import { RequestedPlatform, requestedPlatformDisplayNames } from '../platform'; import { promptAsync } from '../prompts'; import { getBranchNameFromChannelNameAsync } from '../update/getBranchNameFromChannelNameAsync'; -import { - UpdateJsonInfo, - formatUpdateMessage, - truncateString as truncateUpdateMessage, -} from '../update/utils'; +import { formatUpdateMessage, truncateString as truncateUpdateMessage } from '../update/utils'; import { PresignedPost, uploadWithPresignedPostWithRetryAsync } from '../uploads'; import { expoCommandAsync, @@ -39,6 +34,7 @@ import chunk from '../utils/expodash/chunk'; import { truthy } from '../utils/expodash/filter'; import uniqBy from '../utils/expodash/uniqBy'; import { Client } from '../vcs/vcs'; +import { resolveWorkflowAsync } from './workflow'; export type ExpoCLIExportPlatformFlag = Platform | 'all'; @@ -298,14 +294,6 @@ export function loadMetadata(distRoot: string): Metadata { return metadata; } -export async function generateEasMetadataAsync( - distRoot: string, - metadata: UpdateJsonInfo[] -): Promise { - const easMetadataPath = path.join(distRoot, 'eas-update-metadata.json'); - await JsonFile.writeAsync(easMetadataPath, { updates: metadata }); -} - export function filterExportedPlatformsByFlag>>( record: T, platformFlag: ExpoCLIExportPlatformFlag From ac9b99804769ae435cad4c879f2411b1e4f3ebe7 Mon Sep 17 00:00:00 2001 From: Quinlan Jung Date: Wed, 17 Jan 2024 20:00:21 -0800 Subject: [PATCH 2/3] lint --- packages/eas-cli/src/project/publish.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/eas-cli/src/project/publish.ts b/packages/eas-cli/src/project/publish.ts index 0c468749f8..688a7e06ea 100644 --- a/packages/eas-cli/src/project/publish.ts +++ b/packages/eas-cli/src/project/publish.ts @@ -12,6 +12,7 @@ import nullthrows from 'nullthrows'; import path from 'path'; import promiseLimit from 'promise-limit'; +import { resolveWorkflowAsync } from './workflow'; import { selectBranchOnAppAsync } from '../branch/queries'; import { getDefaultBranchNameAsync } from '../branch/utils'; import { ExpoGraphqlClient } from '../commandUtils/context/contextUtils/createGraphqlClient'; @@ -34,7 +35,6 @@ import chunk from '../utils/expodash/chunk'; import { truthy } from '../utils/expodash/filter'; import uniqBy from '../utils/expodash/uniqBy'; import { Client } from '../vcs/vcs'; -import { resolveWorkflowAsync } from './workflow'; export type ExpoCLIExportPlatformFlag = Platform | 'all'; From 7da5473b8f2db9038238e23ff8df286bd4f0af15 Mon Sep 17 00:00:00 2001 From: Quinlan Jung Date: Thu, 18 Jan 2024 04:07:12 +0000 Subject: [PATCH 3/3] update CHANGELOG.md --- CHANGELOG.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 378d507300..24ca2043a1 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -6,6 +6,8 @@ This is the log of notable changes to EAS CLI and related packages. ### 🛠 Breaking changes +- Stop generating eas-update-metadata.json on publish. ([#2187](https://github.com/expo/eas-cli/pull/2187) by [@quinlanj](https://github.com/quinlanj)) + ### 🎉 New features - Add `build:delete` command. ([#2178](https://github.com/expo/eas-cli/pull/2178) by [@radoslawkrzemien](https://github.com/radoslawkrzemien))