Sharing errors

[AdrianMrn]

In ignition for PHP, I believe this is done through the package, so we'll have to find a viable alternative for this. I don't think this will be too difficult to accomplish in JS.

[AdrianMrn]

@mpociot I'd like to add the share functionality to ignition-js, but I'm not sure what endpoint to send the reports to.

In php ignition, I think this happens here, but I'm not sure where the actual sending is happening, or what endpoint is being used: https://github.com/facade/ignition/blob/2c7097f942a083bc131c7dd526dd55134532ca71/src/Http/Controllers/ShareReportController.php#L12

Any ideas?

[mpociot]

@AdrianMrn it happens in here: https://github.com/facade/ignition/blob/master/src/Actions/ShareReportAction.php#L32-L36

So you send the report object, the selected tabs and line selection to the public-reports endpoint

[AdrianMrn]

Awesome :) that shouldn't be too difficult

[AdrianMrn]

@mpociot Do you have any idea why the report needs to be stringified when sharing? I can't seem to find anything in the Ignition codebase that really depends on it except for this:
https://github.com/facade/ignition/blob/2c7097f942a083bc131c7dd526dd55134532ca71/src/Http/Controllers/ShareReportController.php#L14

It seems to "just work" if I send the report as an object and remove the json_decode.

We're stringifying it here:
https://github.com/facade/ignition-ui/blob/e68801212cf25e2e6c89222556a28f840d2d88b7/src/js/components/Shared/ShareButton.vue#L94

Do you think I can change it to be sent normally instead? The public-reports endpoint in Flare expects it not-stringified, and I'd rather not have to add in any hacks to change the behaviour of the report button for js errors.