From bc5614ec74d750dc3c2ab11d64a7085565e07670 Mon Sep 17 00:00:00 2001 From: Amanjeev Sethi Date: Thu, 9 Jan 2025 14:24:54 -0500 Subject: [PATCH] Review: Capitalize first letter of messages. --- crates/criticalup-cli/src/commands/clean.rs | 4 ++-- .../cli__clean__clean_deletes_only_unused_installations.snap | 4 ++-- ...ean_deletes_only_unused_installations_also_from_disk.snap | 5 ++--- ...nused_installations_from_disk_that_do_not_have_state.snap | 4 ++-- 4 files changed, 8 insertions(+), 9 deletions(-) diff --git a/crates/criticalup-cli/src/commands/clean.rs b/crates/criticalup-cli/src/commands/clean.rs index 1f6a763f..b4a48f10 100644 --- a/crates/criticalup-cli/src/commands/clean.rs +++ b/crates/criticalup-cli/src/commands/clean.rs @@ -73,7 +73,7 @@ async fn delete_unused_installations(installations_dir: &Path, state: &State) -> let installation_dir_to_delete = installations_dir.join(&installation.0); if installation_dir_to_delete.exists() { tracing::info!( - "deleting unused installation directory {}", + "Deleting unused installation directory {}", &installation_dir_to_delete.display() ); fs::remove_dir_all(&installation_dir_to_delete) @@ -103,7 +103,7 @@ async fn delete_untracked_installation_dirs( if !installations_in_state.contains_key(&InstallationId(name.into())) { are_untracked_installation_dirs_present = true; tracing::info!( - "deleting untracked installation directory {}", + "Deleting untracked installation directory {}", item.path().to_path_buf().display() ); diff --git a/crates/criticalup-cli/tests/snapshots/cli__clean__clean_deletes_only_unused_installations.snap b/crates/criticalup-cli/tests/snapshots/cli__clean__clean_deletes_only_unused_installations.snap index 97b0d674..d2ca023a 100644 --- a/crates/criticalup-cli/tests/snapshots/cli__clean__clean_deletes_only_unused_installations.snap +++ b/crates/criticalup-cli/tests/snapshots/cli__clean__clean_deletes_only_unused_installations.snap @@ -9,8 +9,8 @@ empty stdout stderr ------ INFO Deleting unused installation installation_id_2 - INFO deleting unused installation directory /path/to/toolchain/installation/installation_id_2/ + INFO Deleting unused installation directory /path/to/toolchain/installation/installation_id_2/ INFO Deleting unused installation installation_id_3 - INFO deleting unused installation directory /path/to/toolchain/installation/installation_id_3/ + INFO Deleting unused installation directory /path/to/toolchain/installation/installation_id_3/ INFO no untracked installation directories found ------ diff --git a/crates/criticalup-cli/tests/snapshots/cli__clean__clean_deletes_only_unused_installations_also_from_disk.snap b/crates/criticalup-cli/tests/snapshots/cli__clean__clean_deletes_only_unused_installations_also_from_disk.snap index 60c69bc0..d2ca023a 100644 --- a/crates/criticalup-cli/tests/snapshots/cli__clean__clean_deletes_only_unused_installations_also_from_disk.snap +++ b/crates/criticalup-cli/tests/snapshots/cli__clean__clean_deletes_only_unused_installations_also_from_disk.snap @@ -1,7 +1,6 @@ --- source: crates/criticalup-cli/tests/cli/clean.rs expression: repr -snapshot_kind: text --- exit: exit status: 0 @@ -10,8 +9,8 @@ empty stdout stderr ------ INFO Deleting unused installation installation_id_2 - INFO deleting unused installation directory /path/to/toolchain/installation/installation_id_2/ + INFO Deleting unused installation directory /path/to/toolchain/installation/installation_id_2/ INFO Deleting unused installation installation_id_3 - INFO deleting unused installation directory /path/to/toolchain/installation/installation_id_3/ + INFO Deleting unused installation directory /path/to/toolchain/installation/installation_id_3/ INFO no untracked installation directories found ------ diff --git a/crates/criticalup-cli/tests/snapshots/cli__clean__removes_unused_installations_from_disk_that_do_not_have_state.snap b/crates/criticalup-cli/tests/snapshots/cli__clean__removes_unused_installations_from_disk_that_do_not_have_state.snap index 0b172bcb..e7c3016c 100644 --- a/crates/criticalup-cli/tests/snapshots/cli__clean__removes_unused_installations_from_disk_that_do_not_have_state.snap +++ b/crates/criticalup-cli/tests/snapshots/cli__clean__removes_unused_installations_from_disk_that_do_not_have_state.snap @@ -9,6 +9,6 @@ empty stdout stderr ------ INFO Deleting unused installation installation_id_2 - INFO deleting unused installation directory /path/to/toolchain/installation/installation_id_2/ - INFO deleting untracked installation directory /path/to/toolchain/installation/installation_id_3/ + INFO Deleting unused installation directory /path/to/toolchain/installation/installation_id_2/ + INFO Deleting untracked installation directory /path/to/toolchain/installation/installation_id_3/ ------