Skip to content

Commit

Permalink
Fix installation of PHP dependencies in GitHub Actions
Browse files Browse the repository at this point in the history
Ensure platform requirement (PHP) is checked to ensure the appropriate dependencies are installed.

For example, ignoring that the platform is PHP 8.0 would install a version of symfony/console that expectes PHP 8.1.
  • Loading branch information
mcaskill committed Aug 6, 2024
1 parent f469ba9 commit 6b2b42f
Showing 1 changed file with 1 addition and 10 deletions.
11 changes: 1 addition & 10 deletions .github/workflows/continuous-integration.yml
Original file line number Diff line number Diff line change
Expand Up @@ -64,21 +64,12 @@ jobs:
max_attempts: 5
command: composer require "vlucas/phpdotenv:${{ matrix.phpdotenv-version }}" --no-update --no-interaction

- name: Install PHP 7 dependencies
- name: Install PHP dependencies
uses: nick-invision/retry@v1
with:
timeout_minutes: 5
max_attempts: 5
command: composer update --prefer-dist --no-interaction --no-progress
if: "matrix.php-version < 8"

- name: Install PHP 8 dependencies
uses: nick-invision/retry@v1
with:
timeout_minutes: 5
max_attempts: 5
command: composer update --prefer-dist --no-interaction --no-progress --ignore-platform-req=php
if: "matrix.php-version >= 8"

- name: "Run PHP_CodeSniffer"
run: "composer cs-check"
Expand Down

0 comments on commit 6b2b42f

Please sign in to comment.