Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatile with prestissimo plugin #21

Closed
szepeviktor opened this issue Apr 25, 2020 · 8 comments
Closed

Incompatile with prestissimo plugin #21

szepeviktor opened this issue Apr 25, 2020 · 8 comments

Comments

@szepeviktor
Copy link
Contributor

szepeviktor commented Apr 25, 2020

I think it tries to download from the stored URL.

    62/67:      https://codeload.github.com/symfony/polyfill-ctype/legacy.zip/550ebaac289296ce228a706d0867afc34687e3f4
    0: :        https://connect.advancedcustomfields.com/index.php
    63/67:      https://codeload.github.com/squizlabs/PHP_CodeSniffer/legacy.zip/65b12cdeaaa6cd276d4c3033a95b9b88b12701e7

https://github.com/hirak/prestissimo

May be related to hirak/prestissimo#219

Please advise.

@ffraenz
Copy link
Owner

ffraenz commented Apr 25, 2020

Please provide your composer.json or a similar test case to reproduce the bug. What do you mean by 'the stored URL'?

@szepeviktor
Copy link
Contributor Author

szepeviktor commented Apr 25, 2020

  1. composer global require hirak/prestissimo
  2. Set up private-composer-installer with e.g. ACF Pro
  3. run composer update
  4. See the output above: prestissimo fails to preload ACF Pro, it keeps trying for a while...
  5. Then in installation phase Composer finally downloads ACF Pro from the correct URL (not from local cache as every other package)

@szepeviktor
Copy link
Contributor Author

What do you mean by 'the stored URL'?

the one without secrets, with placeholders

@szepeviktor
Copy link
Contributor Author

so actually prestissimo abuses the ACF download server...

@mcaskill
Copy link
Contributor

mcaskill commented Sep 6, 2020

@szepeviktor Are you using the correct URI and placeholders for dist.url as shown on the README?

https://connect.advancedcustomfields.com/index.php?a=download&p=pro&k={%ACF_PRO_KEY}&t={%VERSION}

As for hirak/prestissimo#219, that is related affecting pivvenit/acf-pro-installer and is related to this: PhilippBaschke/acf-pro-installer#20.

@szepeviktor
Copy link
Contributor Author

I think yes. It was long time ago.

"https://connect.advancedcustomfields.com/index.php?p=pro&a=download&t={%VERSION}&k={%ACF_PRO_KEY}"

@ffraenz
Copy link
Owner

ffraenz commented Oct 27, 2020

@szepeviktor Is this still relevant or may I close this issue?

@szepeviktor
Copy link
Contributor Author

Let's close it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants