Skip to content
This repository has been archived by the owner on Nov 9, 2022. It is now read-only.

DiscountRate Factory param rename. #130

Open
amarcu opened this issue May 2, 2022 · 0 comments
Open

DiscountRate Factory param rename. #130

amarcu opened this issue May 2, 2022 · 0 comments
Assignees
@amarcu
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@amarcu
Copy link
Member

amarcu commented May 2, 2022 •
edited by cleanunicorn
Loading

Context

Currently the Discount Rate Factories use and define the RateId as tokenId which can lead to confusion.

Details

In order to have the same naming convention for all protocol contracts we should use the same naming convention.

Contracts that will contain renames:

  • NotionalFinanceFactory.sol: tokenId renamed to rateId
  • YieldFactory.sol: tokenId renamed to rateId

Alternatives

No

Security concerns

No

Has the feature been requested before?

No
@amarcu amarcu added enhancement New feature or request help wanted Extra attention is needed labels May 2, 2022
@amarcu amarcu self-assigned this May 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@amarcu amarcu

Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@amarcu