-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: show a link to the Dev UI on running evals #2024
base: main
Are you sure you want to change the base?
Conversation
projectRoot?: string | ||
): Promise<string | undefined> { | ||
const serversDir = await findServersDir(projectRoot); | ||
const toolsJsonPath = path.join(serversDir, 'tools.json'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you're always writing to tools.json
? this assumes we track only the last instance of the dev ui? do we want to track all instances?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not know that we'd have multiple Dev UI instances on the same runtime. What would the difference between the instances be?
I can add support for multiple instances if we want, I just need some direction on how we do that for other state files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume like if you're working on a local version of the Dev UI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dont think we can handle supporting a local Dev UI, as it is a separate process entirely and not tracked through genkit start
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added support for multiple Dev UI servers, PTAL.
Co-authored-by: Pavel Jbanov <pavelj@google.com>
Fixes: #1641
Checklist (if applicable):