Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add span for prompt template rendering #2165

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

MichaelDoyle
Copy link
Member

Fixes #2064

image

Checklist (if applicable):

@MichaelDoyle MichaelDoyle requested a review from pavelgj February 25, 2025 03:23
@github-actions github-actions bot added the js label Feb 25, 2025
@pavelgj
Copy link
Collaborator

pavelgj commented Feb 25, 2025

Can you share the code snippet that produces the trace in the screenshot?

@MichaelDoyle
Copy link
Member Author

MichaelDoyle commented Feb 25, 2025

hello.history.prompt

---
model: googleai/gemini-1.5-flash
config:
  maxOutputTokens: 2048
  temperature: 0.6
  topK: 16
  topP: 0.95
  safetySettings:
    - category: HARM_CATEGORY_HATE_SPEECH
      threshold: BLOCK_ONLY_HIGH
    - category: HARM_CATEGORY_DANGEROUS_CONTENT
      threshold: BLOCK_ONLY_HIGH
    - category: HARM_CATEGORY_HARASSMENT
      threshold: BLOCK_ONLY_HIGH
    - category: HARM_CATEGORY_SEXUALLY_EXPLICIT
      threshold: BLOCK_ONLY_HIGH
input:
  schema:
    name: string
    persona?: string
  default:
    persona: Space Pirate
---

{{role "system"}}
You are a helpful AI assistant that really loves to make impressions.
{{role "user"}}
Say hello to Michael in the voice of a Space Pirate.
{{role "model"}}
Shiver me timbers, matey! We be sailing the solar winds!
{{role "user"}}
Say hello to {{name}} in the voice of a {{persona}}.

flowDotPromptHistory

export const HelloSchema = z.object({
  name: z.string(),
  persona: z.string().optional(),
});

ai.defineFlow(
  {
    name: 'flowDotPromptHistory',
    inputSchema: HelloSchema,
    outputSchema: z.any(),
  },
  async (input) => {
    const hello = ai.prompt('hello', {
      variant: 'history',
    });
    return (await hello(input)).text;
  }
);

Copy link
Contributor

@schnecle schnecle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be hugely helpful for understanding when rendering issues are causing problems. Thanks Mike!

@pavelgj
Copy link
Collaborator

pavelgj commented Feb 26, 2025

hello.history.prompt

---
model: googleai/gemini-1.5-flash
config:
  maxOutputTokens: 2048
  temperature: 0.6
  topK: 16
  topP: 0.95
  safetySettings:
    - category: HARM_CATEGORY_HATE_SPEECH
      threshold: BLOCK_ONLY_HIGH
    - category: HARM_CATEGORY_DANGEROUS_CONTENT
      threshold: BLOCK_ONLY_HIGH
    - category: HARM_CATEGORY_HARASSMENT
      threshold: BLOCK_ONLY_HIGH
    - category: HARM_CATEGORY_SEXUALLY_EXPLICIT
      threshold: BLOCK_ONLY_HIGH
input:
  schema:
    name: string
    persona?: string
  default:
    persona: Space Pirate
---

{{role "system"}}
You are a helpful AI assistant that really loves to make impressions.
{{role "user"}}
Say hello to Michael in the voice of a Space Pirate.
{{role "model"}}
Shiver me timbers, matey! We be sailing the solar winds!
{{role "user"}}
Say hello to {{name}} in the voice of a {{persona}}.

flowDotPromptHistory

export const HelloSchema = z.object({
  name: z.string(),
  persona: z.string().optional(),
});

ai.defineFlow(
  {
    name: 'flowDotPromptHistory',
    inputSchema: HelloSchema,
    outputSchema: z.any(),
  },
  async (input) => {
    const hello = ai.prompt('hello', {
      variant: 'history',
    });
    return (await hello(input)).text;
  }
);

So, what I'm thinking is that perhaps the traces should look something like this:

hello.history
  |- render
  |- generate
    |- googleai/gemini-1.5-flash

os do you think it would get too verbose? extra span with redundant info?

Semi-related: I was also chatting with Shruti yesterday... I think we should change render to return GenereateActionOptions instead of GenerateRequest....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

[JS] Prompt executions should have their own span
3 participants