fix: set prompt metadata for render action as expected by dev ui #2180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelDoyle
commented
Feb 27, 2025
| @@ -784,7 +785,7 @@ function loadPrompt( | |||
| type: 'prompt', | |||
| prompt: { | |||
| ...promptMetadata, | |||
| template: source, | |||
| template: parsedPrompt.template, | |||
There was a problem hiding this comment.
Set the template to just the body, w/o the yaml header.
MichaelDoyle
commented
Feb 27, 2025
| @@ -395,6 +395,7 @@ function promptMetadata(options: PromptConfig<any, any, any>) { | |||
| return { | |||
| ...options.metadata, | |||
| prompt: { | |||
| ...options.metadata?.prompt, | |||
There was a problem hiding this comment.
I don't know the history here, but copying existing metadata.prompt as the base, and then overriding with the few options below that were already present.
pavelgj
reviewed
Feb 27, 2025
There was a problem hiding this comment.
Do you mind adding unit tests for the metadata (can probably just add some assertions to existing tests)? I just feel like you've fixed this in the past and I broke it again...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist (if applicable):