Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Tag feature enable/disable as a configuration #69

Open
JoPeAlmeida opened this issue Mar 3, 2022 · 6 comments
Open

Allow Tag feature enable/disable as a configuration #69

JoPeAlmeida opened this issue Mar 3, 2022 · 6 comments
Labels
enhancement New feature or request

Comments

@JoPeAlmeida
Copy link

JoPeAlmeida commented Mar 3, 2022

I want to disable the tag feature
This should something we could enable/disable in configurations

The main issue why I'm asking this is because if someone uses @ by mistake and the tag failed (matches too many) then the message is not sent to discord

@JoPeAlmeida
Copy link
Author

i tried use filters to filter @
but it doesn't work, error message is still sent, ignoring any filter

@fjaros
Copy link
Owner

fjaros commented Mar 12, 2022

that's not how the code works. the message will still be sent to discord without tagging anyone.
you can disable the "matches too many" notification by setting enable_tag_failed_notifications=0 in the config

@JoPeAlmeida
Copy link
Author

JoPeAlmeida commented Mar 13, 2022

the only message sent to discord is this one: Your tag @s matches too many channel members. Be more specific in your tag!

enable_tag_failed_notifications=0 wouldn't this make it enabled? i don't want the bot whispering random people from global this warning

 # If a tag matching fails from Discord when someone @ a non-existent or unmatched person or role,
 # the bot will whisper back notifying so.
 enable_tag_failed_notifications=1

this is what is written in the about this config

@JoPeAlmeida
Copy link
Author

JoPeAlmeida commented Mar 13, 2022

that's not how the code works. the message will still be sent to discord without tagging anyone. you can disable the "matches too many" notification by setting enable_tag_failed_notifications=0 in the config

I understand that's not how the code works, that's why I am asking this as a feature
a new specific config that disables/enables tagging

@fjaros
Copy link
Owner

fjaros commented Mar 13, 2022

That's fine. I don't consider this a high priority though. Since to solve your problem, all you have to do is set enable_tag_failed_notifications=0 to disable warnings about matching too many tags. Then, only the message itself will be sent to discord without any tags being applied.

@JoPeAlmeida
Copy link
Author

i am trying this, so far nothing but this was not happening that often, so lets see

thanks for the help and for considering this a maybe feature ;)

@fjaros fjaros added the enhancement New feature or request label Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants