Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issues when queue constraint does not match queue name #5686

Closed
garlick opened this issue Jan 17, 2024 · 3 comments
Closed

issues when queue constraint does not match queue name #5686

garlick opened this issue Jan 17, 2024 · 3 comments

Comments

@garlick
Copy link
Member

garlick commented Jan 17, 2024

Problem: configuring a queue name that doesn't match the queue constraint is not well tested and may have some problems.

Ryan noted that the QUEUE column is missing in flux resource list, for example.

More checking needed. If this is a requirement, it does not seem to be documented. The admin guide for example just says it's a good practice:

https://flux-framework.readthedocs.io/en/latest/guides/admin-guide.html#adding-queues

@grondo
Copy link
Contributor

grondo commented Jan 18, 2024

This seems to work fine:

#!/bin/bash -e
flux R encode -r 0-3 -p foo:0-1 -p bar:2-3 \
   | tr -d "\n" \
   | flux kvs put -r resource.R=- &&

printf "added foo,bar properties to resource.R\n"

flux config load <<EOF
[queues.batch]
requires = [ "bar" ]
[queues.debug]
requires = [ "foo" ]
EOF

printf "added queues batch,debug to config\n"

flux queue start --all
flux module remove -f sched-simple
flux module remove -f sched-fluxion-qmanager
flux module remove -f sched-fluxion-resource
flux module reload resource noverify
flux module load sched-simple

flux queue list

flux resource list
$ flux start -s 4 ./t.sh
added foo,bar properties to resource.R
added queues batch,debug to config
batch: Scheduling is started
debug: Scheduling is started
QUEUE    DEFAULTTIME  TIMELIMIT     NNODES     NCORES      NGPUS
batch            inf        inf      0-inf      0-inf      0-inf
debug            inf        inf      0-inf      0-inf      0-inf
     STATE QUEUE      PROPERTIES NNODES   NCORES    NGPUS NODELIST
      free debug      foo             2        2        0 pi[3,3]
      free batch      bar             2        2        0 pi[3,3]
 allocated                            0        0        0 
      down                            0        0        0 

The recommendation is probably there to avoid the unnecessary PROPERTIES column (flux resource list automatically suppresses properties that match the queue name.)

Ok to close?

@grondo
Copy link
Contributor

grondo commented Jan 19, 2024

I submitted a clarification to the docs here. Maybe once that PR is merged this issue can be closed?

@grondo
Copy link
Contributor

grondo commented Jan 24, 2024

I am going to close this since the title may be misleading. A clarifying PR has been submitted to the admin guide.

@grondo grondo closed this as completed Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants