Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Base: re-think market cap value in nav #954

Open
yayay927 opened this issue Aug 4, 2022 · 0 comments
Open

Base: re-think market cap value in nav #954

yayay927 opened this issue Aug 4, 2022 · 0 comments

Comments

@yayay927
Copy link
Contributor

yayay927 commented Aug 4, 2022

Currently in title bar it's calculated as:

const exludedItems = [null, 0];
const marketCap = exludedItems.includes(data.marketCap) ? 'N/A' : `$${formatNumber(data.marketCap.toString(), 2)}`;

Suggested conversion to take into consideration of token price:

  1. check if the returned price is 0
  2. if the returned price is 0, then the market cap can be 0. Otherwise, if the price is not 0, but the returned market cap is 0, show N/A because the two values mismatch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant