Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error handling #13

Closed
declark1 opened this issue May 2, 2024 · 0 comments · Fixed by #31
Closed

Improve error handling #13

declark1 opened this issue May 2, 2024 · 0 comments · Fixed by #31
Assignees
Labels
enhancement New feature or request

Comments

@declark1
Copy link
Collaborator

declark1 commented May 2, 2024

Description

Improve error handling:

  • Determine the appropriate level of error granularity and add variants to capture context or use anyhow::Error (with it's Context trait)
    • e.g. rather than returning Error::ReqwestError, we probably want something like Error::Detector("request timed out")
  • Ensure errors flow up cleanly from orchestrator tasks, we should not be using Result::unwrap()
  • Properly convert Error variants into suitable http::StatusCode (with a message for context) to return to caller from handler methods
@declark1 declark1 added the enhancement New feature or request label May 2, 2024
@evaline-ju evaline-ju linked a pull request May 23, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant