Allow numbers < 100 to be input #34

ronkorving · 2021-04-01T06:59:52Z

Fixes #20

This also:

cleans up the test suite a bit (I added some tests, made them all fail more verbosely and categorized them).
fixes numbers in the readme to be string instead of integer.

ronkorving · 2021-04-02T01:45:06Z

index.js

@@ -18,8 +18,10 @@ var country = function(country) {
  });
 };
 var number = function(number) {
+  number = ('000' + number).slice(-3);


I could've used String(number).padStart(3, '0'), but that requires Node 8. I don't know which version of Node you're intending to support, not to mention browsers, but given that all the JavaScript I see here is fairly legacy, I went with the safe option.

GitHub added 2 commits April 1, 2021 15:48

Cleaned up test suite

fd7f9c5

Allow lookup using numbers < 100 (fixes freeall#20)

a141460

ronkorving force-pushed the improvements branch from 83c0048 to a141460 Compare April 1, 2021 07:01

Change incorrect integer numbers to string in the ReadMe

15ff0ac

ronkorving commented Apr 2, 2021

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow numbers < 100 to be input #34

Allow numbers < 100 to be input #34

ronkorving commented Apr 1, 2021 •

edited

Loading

ronkorving Apr 2, 2021 •

edited

Loading

Allow numbers < 100 to be input #34

Are you sure you want to change the base?

Allow numbers < 100 to be input #34

Conversation

ronkorving commented Apr 1, 2021 • edited Loading

ronkorving Apr 2, 2021 • edited Loading

Choose a reason for hiding this comment

ronkorving commented Apr 1, 2021 •

edited

Loading

ronkorving Apr 2, 2021 •

edited

Loading