Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install the freelens-node-pod-menu extension in Freelens by default #129

Closed
robertobandini opened this issue Feb 3, 2025 · 4 comments · Fixed by #134
Closed

Install the freelens-node-pod-menu extension in Freelens by default #129

robertobandini opened this issue Feb 3, 2025 · 4 comments · Fixed by #134
Assignees
Labels
enhancement New feature or request

Comments

@robertobandini
Copy link
Member

What would you like to be added:
The "freelens-node-pod-menu" extension should be installed by default in the Freelens application.

Why is this needed:
Its features, namely log view and exec for containers, are considered essential.
This is why it was already planned to reintegrate them directly into the application without having to install an extension.
It should therefore also be evaluated whether it is better to proceed directly to reintegrate them into the application or to first install the extension automatically by default and then subsequently reintegrate it into the core.

@robertobandini robertobandini added the enhancement New feature or request label Feb 3, 2025
@robertobandini robertobandini moved this to Todo in freelens Feb 3, 2025
@robertobandini robertobandini added the help wanted Extra attention is needed label Feb 5, 2025
@mariomamo
Copy link
Collaborator

I'm working on it

@robertobandini robertobandini removed the help wanted Extra attention is needed label Feb 5, 2025
@mariomamo
Copy link
Collaborator

mariomamo commented Feb 8, 2025

I think I spotted a bug in the plugin: the container status in the "Logs" menu is always shown as green (ready status), even when the container is pending or stopped. I have fixed this issue in this update but let me know if I am wrong

Plugin Screenshots

Stopped status

Image

Pending status

Image

In-product Porting Screenshots

Stopped status

Image

Pending status

Image

@robertobandini
Copy link
Member Author

Hi @mariomamo and thansk!
II don't know if I remember correctly now, but I would also say that they should be consistent. @dex4er, do you agree?
From the images you indicated, however, it seems to me that the stopped container still has a difference in color.
I think that the right one in that case is black, which indicates that the init container has finished its work.
If I remember badly, I ask anyone else to correct me or give their opinion. Thanks

@mariomamo
Copy link
Collaborator

You are right @robertobandini, I fixed it! 😃 The same issue was present also in the pending state

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants