Installation of the incorrect plugin never ends

[mariomamo]

Describe the bug
Attempting to install a plugin causes the install button to load indefinitely without completing the process.

To Reproduce
Steps to reproduce the behavior:

1. Go to 'File -> Extensions'.
2. Enter @alebcay/openlens-node-pod-menu in Name or file path or URL to an extension package or drag and drop a .tar file, or browse using the file picker.
3. Click on the Install button.
4. The button will start an animation that never ends, and the plugin will not be installed.

Expected behavior
The installation process should either complete successfully, resulting in the plugin being installed, or fail with an error message, ensuring the plugin is not installed.

Screenshots

Environment:

• Freelens Version: 0.1.2
• Extension API: 0.1.2
• Electron: 22.3.3
• Chrome: 108.0.5359.215
• Node: 16.17.1
• Architecture: x64
• OS: Windows 11
• Installation method: .exe file downloaded from github release page

[robertobandini]

Hi @mariomamo, did you check the readme on this repo? You should use @freelensapp/freelens-node-pod-menu I close this issue, but please repoen if you still have problems about that. Thanks!

fyi @dex4er

[mariomamo]

Hi @robertobandini,

No, I didn’t. My bad, I’m sorry.
I successfully installed the plugin you suggested, thanks! 😃

Wouldn’t it be better to return an error in case someone enters a wrong link, like I did?

Also, I just want to thank you and the rest of the team for the work you’re all doing on this project. It’s incredibly useful 😄

[robertobandini]

Wouldn’t it be better to return an error in case someone enters a wrong link, like I did?

Yes I agree! Can you open an issue about this idea? Or if you want you can even try to resolve it and do a PR.
Thank you very much @mariomamo!!

[mariomamo]

Yes, of course!
I will open an issue and try to fix it.

[dex4er]

Actually I would use this issue opened as the main bug is not solved: installation (of the incorrect package) never ends.

[robertobandini]

Thanks @dex4er! @mariomamo Let us know if you need any help! Thanks

[mariomamo]

Hi guys, I just created the pull request for this issue.
To provide some context, the issue was caused by a function waiting indefinitely for the extension ID to be added to a Map. However, in case of exceptions, this never occurs, causing the process to wait forever.

I’ve added a timeout of 10 seconds, which should be sufficient since this function starts after all the extension files have been moved to the extensions folder, and it only reads the manifest file from there.
To ensure it works as expected, I tested it with a 2GB extension file (the maximum allowed size) that I created specifically for this test, and everything worked as intended.