Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type annotations (PEP 484) #451

Closed
dargueta opened this issue Oct 14, 2020 · 2 comments
Closed

Add type annotations (PEP 484) #451

dargueta opened this issue Oct 14, 2020 · 2 comments

Comments

@dargueta
Copy link

For those of us using MyPy in our projects it'd be really helpful to add typing annotations. Now that we only support Python 3.6+ we can do this directly in the code instead of having to use comments. I'd be willing to take this on if owners are interested.

If we don't want to do this in the codebase here I could do it on typeshed but that's less than ideal.

(Probably required for fsspec/s3fs#383)

@racinmat
Copy link

I would really appreciate this.

@ianthomas23
Copy link
Collaborator

There are a number of issues about adding type annotations. I am closing this as a duplicate of #625 as that has the most relevant discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants