Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider using JSON.parse instead of eval #4

Open
neatonk opened this issue Jun 12, 2014 · 0 comments
Open

Consider using JSON.parse instead of eval #4

neatonk opened this issue Jun 12, 2014 · 0 comments

Comments

@neatonk
Copy link

neatonk commented Jun 12, 2014

From freesound.js#L84-87...

if (xhr.readyState === 4 && [200,201,202].indexOf(xhr.status)>=0){
    var data = eval("(" + xhr.responseText + ")");
    if(success) success(wrapper?wrapper(data):data);
}

I believe xhr.responseText is a JSON string, in which case JSON.parse can be used to safely parse the data. Is there a reason eval is used instead?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@neatonk