Skip to content
This repository was archived by the owner on Jun 28, 2024. It is now read-only.

Bot gets stuck when it is holding an item and inventory is full #276

Open
me-rgb opened this issue Jun 9, 2022 · 4 comments
Open

Bot gets stuck when it is holding an item and inventory is full #276

me-rgb opened this issue Jun 9, 2022 · 4 comments
Assignees
Labels
FIXED (next release) Fixed and will appear in the next release major bug Bug where bot gets stuck, requires human intervention Planned Fix
Milestone

Comments

@me-rgb
Copy link

me-rgb commented Jun 9, 2022

Steps to Reproduce (as best as you can)

Use latest release, and it will get stuck. If you open your inventory, it is holding something while its inventory is full, which causes it to get stuck.

Expected Behavior

Throw out unneeded items or throw out item that it is holding

Actual Behavior (What lead to the bot getting permanently stuck)

Does not throw out items, causing the bot to be stuck.

Crashlogs and Screenshots (if applicable)

2022-06-08_23 03 31

Other mods (if applicable)

Discord username (if you want updates)

[]me24345#7751

Developer Notes (leave this blank)

Difficulty: Unkown
Estimated Time Required: ?

We don't know exactly how to replicate this issue yet so a score cannot be evaluated.

@me-rgb me-rgb added the major bug Bug where bot gets stuck, requires human intervention label Jun 9, 2022
@JamesGreen31
Copy link
Contributor

Sorry to get to this so late.

Do you know how to replicate this for sure everytime? I need to know the exact cause. run @gamer isn't really a cause since we don't know if that for sure will cause it.

Something liike "start with X in your inventory, and then do Y and then the bug will happen". Something I can replicate in just a few minutes.

If you can find out the reproducible steps, I can solve this for you.

@johnnybpena1989
Copy link

To replicate this in a few minutes, fill your inventory up with everything you would acquire from running the @gamer command. Eventually it will get stuck holding items (that it should drop) and cannot move on to the next chained event.

@JamesGreen31
Copy link
Contributor

JamesGreen31 commented Mar 22, 2023

#300

@JamesGreen31 JamesGreen31 self-assigned this Jan 23, 2024
@JamesGreen31 JamesGreen31 added this to the 1.18.2 fix milestone Jan 23, 2024
@JamesGreen31 JamesGreen31 mentioned this issue Jan 23, 2024
3 tasks
@JamesGreen31 JamesGreen31 linked a pull request Jan 23, 2024 that will close this issue
3 tasks
@JamesGreen31 JamesGreen31 added the FIXED (next release) Fixed and will appear in the next release label Jan 23, 2024
@JamesGreen31
Copy link
Contributor

The issue was caused by player interaction task chain incorrectly allowing a cursor slot to be clicked. A check was added to prevent this behavior. A potential refactor would include re-working the way slots work, but this is great for now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FIXED (next release) Fixed and will appear in the next release major bug Bug where bot gets stuck, requires human intervention Planned Fix
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants