Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panic instead of a Result<,> #43

Open
JorisDeRidder opened this issue Jan 31, 2025 · 0 comments
Open

Panic instead of a Result<,> #43

JorisDeRidder opened this issue Jan 31, 2025 · 0 comments

Comments

@JorisDeRidder
Copy link

JorisDeRidder commented Jan 31, 2025

varpro sometimes panics instead of returning a Result, which makes it less suitable for "production" code. The underlying reason is a panic of the SVD module in nalgebra library that varpro uses under the hood. This module panics when there is a NaN among the singular values. I created an issue at the nalgbra Github repository #1475, and a kind developer already implemented a fix. There seems to be some delay in accepting his/her pull request, though. As soon as nalgebra implements this fix, I would like to request that varpro uses this new nalgebra version and catch the Result when the fit goes wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant