Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

geocoderUrl should be configurable and/or public #12

Open
dhdaines opened this issue Dec 7, 2023 · 0 comments
Open

geocoderUrl should be configurable and/or public #12

dhdaines opened this issue Dec 7, 2023 · 0 comments

Comments

@dhdaines
Copy link

dhdaines commented Dec 7, 2023

Currently the way this library works requires you to expose your API key in client-side code. The only really secure way around this is to proxy the requests, which implies using a geocoderUrl other than https://api.geoapify.com/v1/geocode/autocomplete

So, it would be nice if the type definitions didn't declare geocoderUrl and placeDetailsUrl as private, or better yet, if there were an option in the constructor / an accessor to modify them.

If there's another solution for protecting the API key let me know!
hovsepyan021 added a commit that referenced this issue Sep 27, 2024
@hovsepyan021
GitHub issue #12
977acb0 
*added method setGeocoderUrl()
*added method setPlaceDetailsUrl()
@hovsepyan021 hovsepyan021 mentioned this issue Sep 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dhdaines