-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Datahub] Add service metadata support #1081
Conversation
Affected libs:
|
📷 Screenshots are here! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, that looks great, thank you!! well done 🙂
I'm approving but it seems that some tests are still failing so we'll have to fix those first
const kind = hierarchyLevel === 'service' ? 'service' : 'dataset' | ||
resourceType: (output, source) => { | ||
const resourceType = selectField(source, 'resourceType') | ||
const kind = resourceType[0] === 'service' ? 'service' : 'dataset' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this sounds counter-intuitive but you should use the atomic operations here:
selectField(
getFirstValue(selectField(source, 'resourceType')),
'key'
)
This is because the documents coming from ES can sometimes have various shapes and atomic operations functions will be tolerant to nullish/unexpected values :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the suggestion!
3039ae6
to
e5ab1ed
Compare
71c50c9
to
80e663f
Compare
80e663f
to
c204243
Compare
Description
This PR completes the support of Service metadata for
gn4
(read),iso19139
(read/write) andiso19115
-3 (read-write).Some fixtures were added:
Architectural changes
The
ServiceRecord
Metadata Model has a newspatialExtents
proprety (likeDatasetRecord
):Quality Assurance Checklist
breaking change
labelbackport <release branch>
label