-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Datahub: fix some issues in query URL generation form #1106
Conversation
Affected libs:
|
📷 Screenshots are here! |
37290df
to
9172df7
Compare
If multiple collections are available in an endpoint then use the name in the online resource instead of the first collection
9172df7
to
d6933a5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jahow thank you for implementing the fix!
When I tested the feature I was wondering if the changes in the url were only applied to the WFS endpoint. In the OGC API form I still see the old format:
Is that how it is supposed to be?
Thanks for the review! This change should be applied to all endpoints, whichever the protocol. Let me take a look |
@Angi-Kinas so I think it's behaving as expected. If you look at: https://data.lillemetropole.fr/data/ogcapi/collections/environnement_energie:jour_collecte?f=json The download link for the mimeType |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jahow Thanks for the clarification. You can go ahead 🚀
* feat(ui): use mimeTypes in API form query url generation * feat(ui): use OGCAPI collection name if available If multiple collections are available in an endpoint then use the name in the online resource instead of the first collection
Description
This PR fixes #1067 to use the correct mime-type when generating an URL in the API form.
This also supports specifying a collection name alongside an OGC API link instead of having the URL already point to a specific collection.
Architectural changes
none
Screenshots
Quality Assurance Checklist
breaking change
labelbackport <release branch>
label