-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Editor: Reorder service as resource fields #1113
Conversation
Affected libs:
|
📷 Screenshots are here! |
b404174
to
b03f874
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this work! I've left a few comments :)
When testing, I noticed that after submitting the link, the fields stay filled (see screenshot) and the button stays focused. This is maybe not a priority, but I would expect them to cleanup/unfocus because the user might want to add another link without having to delete the previous values, WDYT? Something like the spatial extent input is doing. But on the other hand, it's not like the component was doing it before anyway, so you can decide.
...rc/lib/components/online-service-resource-input/online-service-resource-input.component.html
Outdated
Show resolved
Hide resolved
...rc/lib/components/online-service-resource-input/online-service-resource-input.component.html
Outdated
Show resolved
Hide resolved
b03f874
to
0dabf36
Compare
0dabf36
to
ecd04fb
Compare
Thanks for your review!
=> Ok fixed for all gn-ui-button.
=> Ok i have updated the code: now we clear the identifier entry after submit. As for the url I don't know if we should remove it, maybe the user wants to add multiple layer from a same service? Tthis point should be discussed with the UX team maybe? |
2d61523
to
bceb2ce
Compare
Description
This PR changes the display order for the fields in the service-as-a-resource form.
NB. This is preparatory work for next topic (layer name suggestion), some function like
handleServiceUrlChange
andhandleIdentifierSubmit
will be improved/clarified in next ticket.Architectural changes
None
Screenshots
NB. The upload button is hidden for now as there is a new "Link to the service" button. The upload button will be used in next PR for layer suggestion.
Quality Assurance Checklist
breaking change
labelbackport <release branch>
label