-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make e2e more robust #1128
Make e2e more robust #1128
Conversation
Affected libs: Affected apps:
|
5c243a6
to
5965a82
Compare
📷 Screenshots are here! |
8025c1a
to
ed39bda
Compare
1a1457d
to
d6924bc
Compare
d6924bc
to
bc44c06
Compare
cad7404
to
45dfc46
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A big thanks for doing this work! It looks good to me. I'm sure it will improve our CI experience 😃
0f87107
to
34e3e64
Compare
seems all good for me, i hope we will find a solution about the download link |
Description
This PR introduces improvements to the e2e workflow, making the e2e tests less disruptive during development.
beforeEach
block intobeforeAll
(before
in Cypress) => 🛑🛑🛑 KOUnable to switch to
before
(instead ofbeforeAll
), Cypress does not store the state of the browser, it is mandatory to refresh/visit the page for each spec.As a result, here are the changes:
@nx/cypress
)env.AFFECTED_APPS
)cy.readFile()
has been commented indatasetDetailPage.cy.ts
=> I can't find why this does not work with Cypress v13 anymore. It looks like Cypress freezes for this specific case. Intercept seems to not work when downloading on a tag with download attribute. Maybe one other way to test this without downloading the file, would be to check the value of the link and ignore the file content as this is the server responsability to produce the right file.Architectural changes
The following library now depends on Cypress v13.0.0 (introducing
experimentalStrategy
forretries
/flakyness).Screenshots
Example of flaky tests

Now Github bot's comment is reflecting the right affected apps and libs

Quality Assurance Checklist
breaking change
labelbackport <release branch>
label