fix duplicated links OGC API #1134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Affected libs:
|
|
📷 Screenshots are here! |
jahow
changed the title
jahow
reviewed
Feb 26, 2025
| @@ -187,6 +188,7 @@ export class DataService { | |||
| return Object.keys(collectionInfo.bulkDownloadLinks).map((downloadLink) => { | |||
| return { | |||
| ...ogcApiLink, | |||
| name: collectionInfo.title, | |||
There was a problem hiding this comment.
wouldn't you need to use id here? I think title is the human readable label, so it won't match with the WFS feature type
There was a problem hiding this comment.
changed to id, both works
Comment on lines
76
to
87
| getDownloadUrlsFromOgcApi = jest.fn((url: string) => | ||
| url.indexOf('error') > -1 | ||
| ? Promise.reject(new Error('ogc.unreachable.unknown')) | ||
| : Promise.resolve({ | ||
| name: 'collection1', | ||
| title: 'Collection 1', | ||
| bulkDownloadLinks: { | ||
| 'application/geo+json': 'http://example.com/collection1.geojson', | ||
| 'application/json': 'http://example.com/collection1.json', | ||
| }, | ||
| }) | ||
| ) |
There was a problem hiding this comment.
Why did you need to add this change to the test? Is this an improvement to the existing test or was thee a failure?
There was a problem hiding this comment.
i make the mock in the wrong test and i forgot to delete I think. The goal is to see the forcing of the collection name... in the data service spec not this one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is about a bug encontred at MEL. The OGC and WFS links where duplicated because the OGC api does not have a name property linkd to the dataset. So to avoid this, in both OGCApi and WFS services, i reset the collection name. Now both OGC and WFS collection will have the same name, and the duplication remover works.
Architectural changes
The following library now depends on [...]
Screenshots
[...]
Quality Assurance Checklist
breaking changelabelbackport <release branch>label