-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Datahub] Feature catalog - Load attributes description from a linked record if present #1137
base: main
Are you sure you want to change the base?
Conversation
Affected libs: Affected apps:
|
0451715
to
e54e85e
Compare
📷 Screenshots are here! |
97caf72
to
6909b57
Compare
@@ -28,6 +29,21 @@ export const loadFullMetadataFailure = createAction( | |||
props<{ otherError?: string; notFound?: boolean }>() | |||
) | |||
|
|||
export const loadFeatureCatalog = createAction( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jahow says : need to be tested
@@ -2642,6 +2643,7 @@ describe('Gn4Converter', () => { | |||
extras: { | |||
catalogUuid: 'metawal.wallonie.be', | |||
favoriteCount: 0, | |||
featureTypes: [], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jahow says : is there a way to get a test to show that this takes in the correct value? e.g. by changing the mock values used as input?
d9bdc0a
to
f98e22f
Compare
Description
This PR introduces feature catalog. It is a first technical step to load a feature catalog in the record before displaying it in a record page.
Attributes from a feature catalog can be retrieve in two different ways:
featureTypes
propertyrelated.fcats
property: in this case we will store the linked record uuid as property (featureCatalogIdentifier
) and will load (getRecord()
) its definition to get its ownfeatureTypes
Thanks @Guillaume-d-o for your work on this PR.
💡 Example of a record with a linked feature catalog (for Case 2)
Architectural changes
New mappers were added to load
featureTypes
and get thefeatureCatalogIdentifier
.Screenshots
No UI
Quality Assurance Checklist
breaking change
labelbackport <release branch>
label