Skip to content

Commit 38f22e0

Browse files
Add parameter set name table output format of parameters (#3314)
* fix(parameters): improve parameter set table output format - Add "PARAMETER SET" column to distinguish between parameter set name and parameter name - Rename internal variable from paramsSets to result for clarity - Include parameter set name in output rows for better identification - Update table headers to reflect new column structure Signed-off-by: Kim Christensen <kimworking@gmail.com> * fix: Unit test Signed-off-by: Kim Christensen <kimworking@gmail.com> * test: Remove integration test as this is already covered by unit tests Signed-off-by: Kim Christensen <kimworking@gmail.com> --------- Signed-off-by: Kim Christensen <kimworking@gmail.com>
1 parent 471bb28 commit 38f22e0

File tree

2 files changed

+9
-9
lines changed

2 files changed

+9
-9
lines changed

pkg/porter/parameters.go

+5-5
Original file line numberDiff line numberDiff line change
@@ -79,16 +79,16 @@ func (p *Porter) PrintParameters(ctx context.Context, opts ListOptions) error {
7979
tp := dtprinter.DateTimePrinter{
8080
Now: func() time.Time { return now },
8181
}
82-
paramsSets := [][]string{}
82+
result := [][]string{}
8383
for _, ps := range params {
8484
for _, param := range ps.Parameters {
8585
list := []string{}
86-
list = append(list, ps.Namespace, param.Name, param.Source.Strategy, param.Source.Hint, tp.Format(ps.Status.Modified))
87-
paramsSets = append(paramsSets, list)
86+
list = append(list, ps.Namespace, ps.Name, param.Name, param.Source.Strategy, param.Source.Hint, tp.Format(ps.Status.Modified))
87+
result = append(result, list)
8888
}
8989
}
90-
return printer.PrintTableParameterSet(p.Out, paramsSets,
91-
"NAMESPACE", "NAME", "TYPE", "VALUE", "MODIFIED")
90+
return printer.PrintTableParameterSet(p.Out, result,
91+
"NAMESPACE", "PARAMETER SET", "NAME", "TYPE", "VALUE", "MODIFIED")
9292
default:
9393
return fmt.Errorf("invalid format: %s", opts.Format)
9494
}
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
---------------------------------------------------
2-
NAMESPACE NAME TYPE VALUE MODIFIED
3-
---------------------------------------------------
4-
foo secret foo_secret 1983-04-18
1+
------------------------------------------------------------------
2+
NAMESPACE PARAMETER SET NAME TYPE VALUE MODIFIED
3+
------------------------------------------------------------------
4+
mypset foo secret foo_secret 1983-04-18

0 commit comments

Comments
 (0)