Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split out ReactorUtils and required classes from Spring integration #3144

Closed
Angelodaniel opened this issue Jan 17, 2024 · 4 comments
Closed
Assignees
Labels
Platform: Java Sync: Jira apply to auto-create a Jira shadow ticket

Comments

@Angelodaniel
Copy link
Member

Angelodaniel commented Jan 17, 2024

Problem Statement

We already have support for reactor in our Spring integration as part of the WebFlux specifics. Users who are not using Spring would also like to use e.g. ReactorUtils so they don't have to deal with Hub propagation themselves.

Solution Brainstorm

To consider:

Do we want to always bring this new module as a dependency for Spring or do we want to rely on our build plugins to automatically add it and code it in a way where it has to be added manually as a dependency by the user when not using our build plugin auto install feature?

Probably not worth it to make it an optional dependency if it doesn't have any dependencies of its own as it just creates a pitfall.

┆Issue is synchronized with this Jira Improvement by Unito

@Angelodaniel Angelodaniel added Platform: Java Sync: Jira apply to auto-create a Jira shadow ticket labels Jan 17, 2024
@getsantry getsantry bot moved this to Waiting for: Product Owner in GitHub Issues with 👀 2 Jan 17, 2024
@adinauer adinauer changed the title Multi thread supportability for ReactorUtils Split out ReactorUtils and required classes from Spring integration Jan 17, 2024
@Angelodaniel
Copy link
Member Author

Customer mitigated the problem by copying the functionality. So I would say this is low prio @adinauer

@kahest
Copy link
Member

kahest commented Jan 19, 2024

Thanks for the update/workaround @Angelodaniel

@adinauer
Copy link
Member

Thanks @Angelodaniel I've reduce prio a bit but still think we should do this as it's not a lot of work and can help some users running into the same problem.

@lcian
Copy link
Member

lcian commented Feb 24, 2025

Closing this as the feature has been merged in #4155
Post-release tasks are being tracked here #4199

@lcian lcian closed this as completed Feb 24, 2025
@github-project-automation github-project-automation bot moved this from Needs Discussion to Done in Mobile & Cross Platform SDK Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Platform: Java Sync: Jira apply to auto-create a Jira shadow ticket
Projects
Archived in project
Status: Done
Development

No branches or pull requests

4 participants