-
-
Notifications
You must be signed in to change notification settings - Fork 448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include Package Version Information in MANIFEST.MF #4189
Labels
Comments
For example in our Quarkus Logging Sentry extension i want to display the current SDK version on the Dev Card. But can't because your manifest is empty. |
hi @melloware thanks for opening the issue - I don't see any problems with doing that, we're already doing that partially for our otel-agent. We'll look into doing that for other modules too! |
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Integration
sentry
Java Version
11
Version
8.2.0
Steps to Reproduce
Your Manifest is how JARS are identified.
For example:
SentryRuntime.class.getPackage().getImplementationVersion()
returnsNULL
because your manifest is empty.A proper manifest you can genereate with GRADLE easily to look something like this... from Caffeine.
Here is how Temporal.io solved it in their SDK with Gradle.
Expected Result
A MANIFEST.MF with proper identifying entriues.
Actual Result
MANIFEST.MF is blank in all JARS.
The text was updated successfully, but these errors were encountered: