From 93e2628183fb4a833590c654ed57efe73ddf6d1e Mon Sep 17 00:00:00 2001 From: Dominik Dorfmeister Date: Wed, 5 Mar 2025 16:32:56 +0100 Subject: [PATCH] ref(ui): move textarea to components/core (#86381) --- static/app/components/core/input/inputGroup.chonk.tsx | 4 ++-- static/app/components/core/input/inputGroup.tsx | 4 ++-- .../controls/textarea.tsx => core/textarea/index.tsx} | 6 ++---- static/app/components/events/autofix/autofixDiff.tsx | 2 +- static/app/components/featureFeedback/feedbackModal.tsx | 4 ++-- .../widgetBuilder/components/nameAndDescFields.tsx | 2 +- static/app/views/settings/organizationRelay/modals/form.tsx | 4 ++-- .../views/settings/project/projectOwnership/ownerInput.tsx | 2 +- .../views/settings/project/projectOwnership/rulesPanel.tsx | 2 +- 9 files changed, 14 insertions(+), 16 deletions(-) rename static/app/components/{forms/controls/textarea.tsx => core/textarea/index.tsx} (91%) diff --git a/static/app/components/core/input/inputGroup.chonk.tsx b/static/app/components/core/input/inputGroup.chonk.tsx index c9c7fda5d7f71a..d7d32a0d7cf74e 100644 --- a/static/app/components/core/input/inputGroup.chonk.tsx +++ b/static/app/components/core/input/inputGroup.chonk.tsx @@ -2,7 +2,7 @@ import {css, type DO_NOT_USE_ChonkTheme} from '@emotion/react'; import styled from '@emotion/styled'; import {Input} from 'sentry/components/core/input/index'; -import Textarea from 'sentry/components/forms/controls/textarea'; +import {TextArea} from 'sentry/components/core/textarea'; import {space} from 'sentry/styles/space'; import type {FormSize, StrictCSSObject} from 'sentry/utils/theme'; import {chonkStyled} from 'sentry/utils/theme/theme.chonk'; @@ -59,7 +59,7 @@ export const ChonkStyledInput = chonkStyled(Input)` ${chonkInputStyles} `; -export const ChonkStyledTextArea = chonkStyled(Textarea)` +export const ChonkStyledTextArea = chonkStyled(TextArea)` ${chonkInputStyles} `; diff --git a/static/app/components/core/input/inputGroup.tsx b/static/app/components/core/input/inputGroup.tsx index b63e088cf0ef9a..e5fa8a9050467c 100644 --- a/static/app/components/core/input/inputGroup.tsx +++ b/static/app/components/core/input/inputGroup.tsx @@ -21,8 +21,8 @@ import { InputItemsWrap, type InputStyleProps, } from 'sentry/components/core/input/inputGroup.chonk'; -import type {TextAreaProps} from 'sentry/components/forms/controls/textarea'; -import _TextArea from 'sentry/components/forms/controls/textarea'; +import type {TextAreaProps} from 'sentry/components/core/textarea'; +import {TextArea as _TextArea} from 'sentry/components/core/textarea'; import type {FormSize} from 'sentry/utils/theme'; import {withChonk} from 'sentry/utils/theme/withChonk'; diff --git a/static/app/components/forms/controls/textarea.tsx b/static/app/components/core/textarea/index.tsx similarity index 91% rename from static/app/components/forms/controls/textarea.tsx rename to static/app/components/core/textarea/index.tsx index 11880ea64390c6..62914ce3c72020 100644 --- a/static/app/components/forms/controls/textarea.tsx +++ b/static/app/components/core/textarea/index.tsx @@ -39,7 +39,7 @@ const TextAreaControl = forwardRef(function TextAreaControl( TextAreaControl.displayName = 'TextAreaControl'; -const TextArea = styled(Input.withComponent(TextAreaControl), { +export const TextArea = styled(Input.withComponent(TextAreaControl), { shouldForwardProp: (p: string) => ['autosize', 'rows', 'maxRows'].includes(p) || isPropValid(p), })` @@ -52,6 +52,4 @@ const TextArea = styled(Input.withComponent(TextAreaControl), { height: unset; min-height: unset; `} -`; - -export default TextArea as unknown as typeof TextAreaControl; +` as unknown as typeof TextAreaControl; diff --git a/static/app/components/events/autofix/autofixDiff.tsx b/static/app/components/events/autofix/autofixDiff.tsx index c68c9e6178773d..71d9086097e8fc 100644 --- a/static/app/components/events/autofix/autofixDiff.tsx +++ b/static/app/components/events/autofix/autofixDiff.tsx @@ -4,6 +4,7 @@ import {type Change, diffWords} from 'diff'; import {addErrorMessage} from 'sentry/actionCreators/indicator'; import {Button} from 'sentry/components/button'; +import {TextArea} from 'sentry/components/core/textarea'; import AutofixHighlightPopup from 'sentry/components/events/autofix/autofixHighlightPopup'; import { type DiffLine, @@ -12,7 +13,6 @@ import { } from 'sentry/components/events/autofix/types'; import {makeAutofixQueryKey} from 'sentry/components/events/autofix/useAutofix'; import {useTextSelection} from 'sentry/components/events/autofix/useTextSelection'; -import TextArea from 'sentry/components/forms/controls/textarea'; import InteractionStateLayer from 'sentry/components/interactionStateLayer'; import {DIFF_COLORS} from 'sentry/components/splitDiff'; import {IconChevron, IconClose, IconDelete, IconEdit} from 'sentry/icons'; diff --git a/static/app/components/featureFeedback/feedbackModal.tsx b/static/app/components/featureFeedback/feedbackModal.tsx index 068f1c454a8d35..2bd20df98ff60e 100644 --- a/static/app/components/featureFeedback/feedbackModal.tsx +++ b/static/app/components/featureFeedback/feedbackModal.tsx @@ -16,7 +16,7 @@ import type {ModalRenderProps} from 'sentry/actionCreators/modal'; import {Button} from 'sentry/components/button'; import ButtonBar from 'sentry/components/buttonBar'; import {Alert} from 'sentry/components/core/alert'; -import Textarea from 'sentry/components/forms/controls/textarea'; +import {TextArea} from 'sentry/components/core/textarea'; import FieldGroup from 'sentry/components/forms/fieldGroup'; import SelectField from 'sentry/components/forms/fields/selectField'; import type {Data} from 'sentry/components/forms/types'; @@ -307,7 +307,7 @@ export function FeedbackModal({ flexibleControlStateSize stacked > -