From cad13a38d9a081d863203393061eb475d1dfd9ba Mon Sep 17 00:00:00 2001 From: Ryan Albrecht Date: Mon, 3 Mar 2025 15:02:29 -0800 Subject: [PATCH] code comment --- static/app/views/releases/components/useFinalizeRelease.tsx | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/static/app/views/releases/components/useFinalizeRelease.tsx b/static/app/views/releases/components/useFinalizeRelease.tsx index b5f294351fa2f0..bda7d2ff0cc22b 100644 --- a/static/app/views/releases/components/useFinalizeRelease.tsx +++ b/static/app/views/releases/components/useFinalizeRelease.tsx @@ -17,6 +17,12 @@ export default function useFinalizeRelease() { return useMutation({ mutationFn: ([release]) => { + // It's likely that there will either be a) CI setup or b) people manually + // clicking. If people are manually clicking then we try `firstEvent` and + // fall back to `dateCreated` to preserve relative sort order between + // releases. This strategy allows users to manually bucket releases by + // finalized/un-finalized, if they want more precision then CI automation + // is a better approach. const payload: TPayload = { dateReleased: release.firstEvent ?? release.dateCreated, };