Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrations(shared-views): Backfill positions column in groupsearchviewstarred table #86164

Merged
merged 2 commits into from
Mar 5, 2025

Conversation

MichaelSun48
Copy link
Member

We're migrating the positions column from the groupsearchview column to its own table, groupsearchviewstarred. This PR copies all of the position columns to the new table.

An update to the PUT endpoint to ensure the columns remain in sync has already been merged here

Note: this migration is configured as a post-deployment migration.

@MichaelSun48 MichaelSun48 requested a review from a team as a code owner March 1, 2025 01:30
@MichaelSun48 MichaelSun48 changed the title migrations(shared-views): Migration to backfill positions column migrations(shared-views): Backfill positions column in groupsearchviewstarred table Mar 1, 2025
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Mar 1, 2025
@MichaelSun48 MichaelSun48 requested a review from a team March 1, 2025 01:30
Copy link
Contributor

github-actions bot commented Mar 1, 2025

This PR has a migration; here is the generated SQL for src/sentry/migrations/0837_backfill_groupsearchview_positions_to_gsvstarred.py ()

--
-- Raw Python operation
--
-- THIS OPERATION CANNOT BE WRITTEN AS SQL

Copy link

codecov bot commented Mar 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #86164       +/-   ##
===========================================
+ Coverage   42.20%   87.81%   +45.61%     
===========================================
  Files        9718     9753       +35     
  Lines      550836   552602     +1766     
  Branches    21537    21537               
===========================================
+ Hits       232456   485260   +252804     
+ Misses     318031    66993   -251038     
  Partials      349      349               

Copy link
Member

@markstory markstory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, a migration makes sense as we'd need these changes in self-hosted as well.

Copy link
Member

@wedamija wedamija left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comment here, might be worth doing this before running this migration https://github.com/getsentry/sentry/pull/86153/files#r1980156390

@MichaelSun48 MichaelSun48 force-pushed the msun/sharedViews/backfillPositionsColumn branch from 85157bc to 9cf9035 Compare March 5, 2025 19:43
Copy link
Contributor

github-actions bot commented Mar 5, 2025

This PR has a migration; here is the generated SQL for src/sentry/migrations/0838_backfill_groupsearchview_positions_to_gsvstarred.py ()

--
-- Raw Python operation
--
-- THIS OPERATION CANNOT BE WRITTEN AS SQL

@MichaelSun48 MichaelSun48 merged commit f89a334 into master Mar 5, 2025
49 checks passed
@MichaelSun48 MichaelSun48 deleted the msun/sharedViews/backfillPositionsColumn branch March 5, 2025 23:02
philipphofmann pushed a commit that referenced this pull request Mar 6, 2025
…wstarred table (#86164)

We're migrating the positions column from the `groupsearchview` column
to its own table, `groupsearchviewstarred`. This PR copies all of the
position columns to the new table.

An update to the PUT endpoint to ensure the columns remain in sync has
already been merged
[here](#86153)


Note: this migration is configured as a post-deployment migration.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants