-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
migrations(shared-views): Backfill positions column in groupsearchviewstarred table #86164
Conversation
This PR has a migration; here is the generated SQL for --
-- Raw Python operation
--
-- THIS OPERATION CANNOT BE WRITTEN AS SQL |
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #86164 +/- ##
===========================================
+ Coverage 42.20% 87.81% +45.61%
===========================================
Files 9718 9753 +35
Lines 550836 552602 +1766
Branches 21537 21537
===========================================
+ Hits 232456 485260 +252804
+ Misses 318031 66993 -251038
Partials 349 349 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, a migration makes sense as we'd need these changes in self-hosted as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my comment here, might be worth doing this before running this migration https://github.com/getsentry/sentry/pull/86153/files#r1980156390
85157bc
to
9cf9035
Compare
This PR has a migration; here is the generated SQL for --
-- Raw Python operation
--
-- THIS OPERATION CANNOT BE WRITTEN AS SQL |
…wstarred table (#86164) We're migrating the positions column from the `groupsearchview` column to its own table, `groupsearchviewstarred`. This PR copies all of the position columns to the new table. An update to the PUT endpoint to ensure the columns remain in sync has already been merged [here](#86153) Note: this migration is configured as a post-deployment migration.
We're migrating the positions column from the
groupsearchview
column to its own table,groupsearchviewstarred
. This PR copies all of the position columns to the new table.An update to the PUT endpoint to ensure the columns remain in sync has already been merged here
Note: this migration is configured as a post-deployment migration.