-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tours): Apply new styles to existing guides #86215
Conversation
❌ 2 Tests Failed:
View the top 2 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
const GuideAnchorWrapper = styled('span')` | ||
display: inline-block; | ||
width: 100%; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These replicate the internals of useHoverCard
overlay, returning a span with these styles.
Bundle ReportChanges will increase total bundle size by 13.38kB (0.03%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: app-webpack-bundle-array-pushAssets Changed:
Files in
Files in
Files in
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, go some failing tests
This will apply the new styles to the existing guides. It also simplifies the components a bit since they don't actually need a dismiss button anymore (as those are always available).
Screen.Recording.2025-03-03.at.10.35.43.AM.mov