Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gitlab CODEOWNERS with custom groups doesn't parse #86351

Open
joshdales opened this issue Mar 4, 2025 · 5 comments
Open

Gitlab CODEOWNERS with custom groups doesn't parse #86351

joshdales opened this issue Mar 4, 2025 · 5 comments

Comments

@joshdales
Copy link

joshdales commented Mar 4, 2025

Environment

SaaS (https://sentry.io/)

Steps to Reproduce

Import a Gitlab CODEOWERS from connected repo that has named sections with a default owner that maps to mapped teams. eg. we have something that looks something like this:

[Team Core] @org/team-core
folder-1/

[Team Other] @org/team-other
folder-2/

Expected Result

Should parse the CODEOWNERS file and rules correctly, and assign the code that it is owned to the correct team or person.
The documentation about this syntax is here: https://docs.gitlab.com/user/project/codeowners/reference/#set-default-code-owner-for-a-section

Actual Result

Got an error banner that reads

There was 1 ownership issue within Sentry on the latest sync with the CODEOWNERS file

The following usernames do not have an association in the organization: org-name
Core]

And there is a new codeowner entry in the ownership table called [Team

Product Area

Settings - Projects

Link

https://{ORG_SLUG}.sentry.io/settings/projects/{PROJECT_SLUG}/ownership/

DSN

https://42a75d0589aa4085b0a6b61a48f8bead@o1301086.ingest.sentry.io/6570851

Version

No response

@getsantry
Copy link
Contributor

getsantry bot commented Mar 4, 2025

Assigning to @getsentry/support for routing ⏲️

@getsantry
Copy link
Contributor

getsantry bot commented Mar 5, 2025

Routing to @getsentry/product-owners-settings-integrations for triage ⏲️

@getsantry getsantry bot moved this from Waiting for: Support to Waiting for: Product Owner in GitHub Issues with 👀 3 Mar 5, 2025
@getsantry
Copy link
Contributor

getsantry bot commented Mar 5, 2025

Routing to @getsentry/product-owners-issues for triage ⏲️

@sentaur-athena
Copy link
Member

Rerouting to issues because it seems like a codeowner parsing problem.

@JoshFerge
Copy link
Member

Hello, thank you for the issue. It looks like Gitlab's CODEOWNER syntax has some features that github's doesn't, and Sentry only supports Github's syntax at the moment. let me work with the team internally to prioritize. thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

4 participants