Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(flags): add "Issue Flags" distributions tab to flags drawer #86359

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

feat(flags): add "Issue Flags" distributions tab to flags drawer #86359

wants to merge 12 commits into from
+322 −98

Conversation

aliu39
Copy link
Member

@aliu39 aliu39 commented Mar 4, 2025 •
edited
Loading

Closes https://github.com/getsentry/team-replay/issues/550

Screen.Recording.2025-03-04.at.4.15.42.PM.mov
  • TODO: refactor tagDistribution.tsx so the prefetch (from hovering over a card) and link to all values (from clicking a card) behavior is extracted into a wrapper component, which we'll skip for flags.

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Mar 4, 2025
@codecov Codecov
Copy link

codecov bot commented Mar 5, 2025 •
edited
Loading

Bundle Report

Changes will decrease total bundle size by 32.51kB (-0.08%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
app-webpack-bundle-array-push 42.44MB -32.51kB (-0.08%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: app-webpack-bundle-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
chunks/app_components_avatar_actorAvatar_tsx-app_components_avatar_avatarList_tsx-app_components_cha-7ec24d.*.js 5.34kB 1.4MB 0.38%
chunks/app_actionCreators_redirectToProject_tsx-app_actionCreators_sudoModal_tsx-app_components_aler-8bb7ac.*.js (New) 457.64kB 457.64kB 100.0% 🚀
chunks/app_views_issueDetails_groupEventDetails_groupEventDetails_tsx.*.js 11.34kB 372.66kB 3.14%
chunks/app_components_breadcrumbs_tsx-app_components_charts_chartZoom_tsx-app_components_charts_rele-5771a6.*.js (New) 350.29kB 350.29kB 100.0% 🚀
chunks/app_actionCreators_preferences_tsx-app_components_avatar_actorAvatar_tsx-app_components_confi-71c9ce.*.js 18 bytes 301.41kB 0.01%
chunks/app_views_issueDetails_groupDetails_tsx.*.js -3.87kB 170.84kB -2.22%
chunks/app_components_core_radio_index_stories_tsx.*.js 5.49kB 148.93kB 3.83%
chunks/app_views_traces_content_tsx-node_modules_lodash_omitBy_js-node_modules_lodash_partialRight_j-d4a98b.*.js 202 bytes 130.88kB 0.15%
chunks/app_components_charts_areaChart_tsx-app_components_charts_chartZoom_tsx-app_components_charts-9c7462.*.js 103 bytes 118.23kB 0.09%
chunks/app_components_charts_components_dataZoomInside_tsx-app_components_charts_components_toolBox_-b11744.*.js (New) 116.85kB 116.85kB 100.0% 🚀
entrypoints/app.js 14 bytes 108.51kB 0.01%
chunks/gsApp_views_decideCheckout_tsx.*.js 81 bytes 99.22kB 0.08%
chunks/app_components_breadcrumbs_tsx-app_components_charts_areaChart_tsx-app_components_charts_barC-6bab73.*.js 103 bytes 98.36kB 0.1%
chunks/app_views_performance_transactionSummary_transactionSpans_spanDetails_index_tsx.*.js 11.85kB 71.49kB 19.86% ⚠️
chunks/app_components_group_externalIssuesList_externalIssueActions_tsx-app_components_group_externa-739368.*.js 49 bytes 65.65kB 0.07%
chunks/app_components_charts_areaChart_tsx-app_components_charts_components_markArea_tsx-app_compone-c91245.*.js (New) 64.53kB 64.53kB 100.0% 🚀
chunks/app_components_charts_components_dataZoomInside_tsx-app_components_charts_components_toolBox_-698983.*.js (New) 60.32kB 60.32kB 100.0% 🚀
chunks/app_components_charts_components_dataZoomInside_tsx-app_components_charts_components_toolBox_-1e4e8f.*.js -3.65kB 57.54kB -5.96%
chunks/app_views_insights_pages_backend_backendOverviewPage_tsx-node_modules_lodash_partialRight_js.*.js 545 bytes 45.36kB 1.22%
chunks/app_views_explore_charts_index_tsx-app_views_explore_hooks_useAnalytics_tsx-app_views_explore-e86025.*.js 22 bytes 45.22kB 0.05%
chunks/app_components_charts_components_dataZoomInside_tsx-app_components_charts_components_toolBox_-5531f4.*.js -3.61kB 40.95kB -8.11%
chunks/app_views_performance_newTraceDetails_traceAnalytics_tsx.*.js 355 bytes 40.84kB 0.88%
chunks/app_components_charts_areaChart_tsx-app_components_charts_series_scatterSeries_tsx-app_compon-a78653.*.js (New) 39.44kB 39.44kB 100.0% 🚀
chunks/app_components_charts_components_dataZoomInside_tsx-app_components_charts_components_toolBox_-f7da41.*.js (New) 37.75kB 37.75kB 100.0% 🚀
chunks/app_components_charts_components_dataZoomInside_tsx-app_components_charts_components_toolBox_-51a8df.*.js -3.61kB 37.54kB -8.78%
chunks/app_components_feedback_widget_us*kWidget_tsx-app_views_performance_transactionSummary-51d702.fa02d054465eb1347a0f.js (New) 37.52kB 37.52kB 100.0% 🚀
chunks/app_components_compactSelect_list_tsx-app_views_settings_components_text_textBlock_tsx.*.js -85 bytes 37.21kB -0.23%
chunks/app_components_charts_areaChart_tsx-app_components_charts_barChart_tsx-app_components_charts_-9966ba.*.js 103 bytes 36.8kB 0.28%
chunks/app_components_charts_components_dataZoomInside_tsx-app_components_charts_components_toolBox_-b3f1e2.*.js -3.61kB 36.28kB -9.06%
chunks/app_components_feedback_widget_feedbackWidgetButton_tsx-app_views_insights_common_components_-07f64e.*.js 527 bytes 34.54kB 1.55%
chunks/app_components_charts_areaChart_tsx-app_components_charts_series_scatterSeries_tsx-app_compon-4b7996.*.js (New) 34.3kB 34.3kB 100.0% 🚀
chunks/app_components_charts_series_scatterSeries_tsx-app_components_feedback_widget_us*kWidg-2f9105.bbed918939ea59a9291e.js (New) 34.19kB 34.19kB 100.0% 🚀
chunks/app_components_core_alert_alertLink_tsx-app_views_monitors_components_detailsSidebar_tsx-app_-4699da.*.js 349 bytes 33.58kB 1.05%
chunks/app_components_charts_eventsRequest_tsx-app_components_feedback_widget_us*kWidget_tsx--fbb1b9.0a3c483152bb993e3010.js (New) 31.1kB 31.1kB 100.0% 🚀
chunks/app_views_alerts_rules_uptime_details_tsx-node_modules_react-virtualized_dist_es_CellMeasurer-9c0417.*.js 360 bytes 24.79kB 1.47%
chunks/app_components_feedback_widget_us*kWidget_tsx-app_components_performance_transactionSe-feae7d.c776739f599a148ef6c6.js (New) 24.18kB 24.18kB 100.0% 🚀
chunks/app_components_charts_components_dataZoomInside_tsx-app_components_charts_components_toolBox_-4f9b0b.*.js -3.61kB 22.23kB -13.96%
chunks/app_actionCreators_prompts_tsx-app_components_emptyMessage_tsx-app_components_feedback_widget-395f49.*.js -85 bytes 21.28kB -0.4%
chunks/app_views_insights_common_components_insightsLineChartWidget_tsx-app_views_insights_common_co-e286d9.*.js 524 bytes 20.59kB 2.61%
chunks/app_components_feedback_widget_us*kWidget_tsx-app_utils_discover_discoverQuery_tsx-app-c5fefe.a61079c53430658631c2.js (New) 17.41kB 17.41kB 100.0% 🚀
chunks/app_components_feedback_widget_us*kWidget_tsx-app_components_gridEditable_sortLink_tsx-d372f4.77841a4cee051a343867.js (New) 16.21kB 16.21kB 100.0% 🚀
chunks/app_components_dropdownMenu_index_tsx-app_components_emptyStateWarning_tsx-app_views_app_asyn-431e93.*.js 46 bytes 14.3kB 0.32%
chunks/app_components_feedback_widget_us*kWidget_tsx-app_components_performance_transactionSe-f61270.814889b79f848280581f.js (New) 13.36kB 13.36kB 100.0% 🚀
chunks/app_components_charts_areaChart_tsx-app_components_dynamicSampling_investigationRule_tsx-app_-76b79e.*.js (New) 13.25kB 13.25kB 100.0% 🚀
chunks/app_components_onboarding_productSelection_tsx.*.js -113 bytes 12.62kB -0.89%
chunks/app_components_charts_lineChart_tsx-app_components_feedback_widget_us*kWidget_tsx-app_-26fc43.fe68432a4fd1876a7bad.js (New) 12.34kB 12.34kB 100.0% 🚀
chunks/app_components_charts_chartZoom_tsx-app_components_charts_releaseSeries_tsx-app_components_ch-c04b97.*.js (New) 9.85kB 9.85kB 100.0% 🚀
chunks/app_views_insights_common_components_moduleLayout_tsx-app_views_insights_llmMonitoring_compon-1886b3.*.js 524 bytes 9.82kB 5.64% ⚠️
chunks/app_views_issueDetails_groupTags_groupTagsTab_tsx.*.js 74 bytes 5.94kB 1.26%
chunks/app_actionCreators_redirectToProject_tsx-app_actionCreators_sudoModal_tsx-app_components_aler-d18754.*.js (Deleted) -457.02kB 0 bytes -100.0% 🗑️
chunks/app_components_breadcrumbs_tsx-app_utils_performance_quickTrace_quickTraceQuery_tsx-app_utils-00df06.*.js (Deleted) -340.68kB 0 bytes -100.0% 🗑️
chunks/app_components_feedback_widget_us*kWidget_tsx-app_views_projectDetail_index_tsx.9ed81a52623c73268264.js (Deleted) -125.93kB 0 bytes -100.0% 🗑️
chunks/app_components_charts_areaChart_tsx-app_components_charts_chartZoom_tsx-app_components_charts-9d600d.*.js (Deleted) -73.57kB 0 bytes -100.0% 🗑️
chunks/app_utils_discover_discoverQuery_tsx-app_views_performance_vitalDetail_index_tsx-node_modules-d327a6.*.js (Deleted) -69.34kB 0 bytes -100.0% 🗑️
chunks/app_components_charts_areaChart_tsx-app_components_charts_chartZoom_tsx-app_components_charts-967899.*.js (Deleted) -48.53kB 0 bytes -100.0% 🗑️
chunks/app_components_charts_areaChart_tsx-app_components_charts_chartZoom_tsx-app_components_charts-e682fa.*.js (Deleted) -43.47kB 0 bytes -100.0% 🗑️
chunks/app_components_charts_releaseSeries_tsx-app_components_charts_series_scatterSeries_tsx-app_co-3ae83e.*.js (Deleted) -43.2kB 0 bytes -100.0% 🗑️
chunks/app_components_charts_components_dataZoomInside_tsx-app_components_charts_components_toolBox_-4b5dae.*.js (Deleted) -41.88kB 0 bytes -100.0% 🗑️
chunks/app_components_charts_eventsRequest_tsx-app_components_feedback_widget_us*kWidget_tsx--fbb1b9.c87cb78821d9455b4529.js (Deleted) -31.1kB 0 bytes -100.0% 🗑️
chunks/app_components_feedback_widget_us*kWidget_tsx-app_views_performance_transactionSummary-51d702.61687ed4cf7e66846ad9.js (Deleted) -25.7kB 0 bytes -100.0% 🗑️
chunks/app_components_feedback_widget_us*kWidget_tsx-app_components_performance_transactionSe-feae7d.b8fbb44bf20bf1e5a5a8.js (Deleted) -24.18kB 0 bytes -100.0% 🗑️
chunks/app_components_charts_areaChart_tsx-app_components_charts_chartZoom_tsx-app_components_charts-a006e5.*.js (Deleted) -22.26kB 0 bytes -100.0% 🗑️
chunks/app_components_feedback_widget_us*kWidget_tsx-app_utils_discover_discoverQuery_tsx-app-c5fefe.653f62f44f3361ed6d8d.js (Deleted) -17.41kB 0 bytes -100.0% 🗑️
chunks/app_components_feedback_widget_us*kWidget_tsx-app_components_gridEditable_sortLink_tsx-d372f4.e59d903ab7316ea529b9.js (Deleted) -16.21kB 0 bytes -100.0% 🗑️
chunks/app_components_feedback_widget_us*kWidget_tsx-app_components_performance_transactionSe-f61270.c0350bc88497adef1df6.js (Deleted) -13.36kB 0 bytes -100.0% 🗑️
chunks/app_utils_performance_suspectSpans_suspectSpansQuery_tsx-app_views_insights_common_components-7ec332.*.js (Deleted) -12.61kB 0 bytes -100.0% 🗑️
chunks/app_components_charts_lineChart_tsx-app_components_feedback_widget_us*kWidget_tsx-app_-26fc43.c6564f5d19c298f44d98.js (Deleted) -12.34kB 0 bytes -100.0% 🗑️

Files in chunks/app_views_issueDetails_groupEventDetails_groupEventDetails_tsx.*.js:

  • ./app/views/issueDetails/groupTags/tagDistribution.tsx → Total Size: 91.28kB

@aliu39 aliu39 marked this pull request as ready for review March 5, 2025 17:59
@aliu39 aliu39 requested review from a team as code owners March 5, 2025 17:59
@aliu39 aliu39 mentioned this pull request Mar 5, 2025
Merged
aliu39 added a commit that referenced this pull request Mar 5, 2025
@aliu39
chore(flags): FF for iterating on flags distribution flyout (#86407)
b6c02b7 
to be used in #86359
@aliu39 aliu39 requested a review from ryan953 March 5, 2025 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scttcper scttcper scttcper left review comments

@ryan953 ryan953 Awaiting requested review from ryan953

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aliu39 @ryan953 @scttcper