Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decide whether we want to check tracePropagationTargets before attaching tracing headers in OpenTelemetry propagator #124

Open
adinauer opened this issue Feb 17, 2025 · 6 comments
Assignees

Comments

@adinauer
Copy link
Member

Currently Java SDK does not check the target URL against tracePropagationTargets before attaching sentry-trace and baggage headers to an outgoing request.

The URL may have been attached to the span attributes but it might not be there.

Do we want to check before attaching these headers?
Also keep in mind other SDKs that have POTel.

@cleptric
Copy link
Member

@adinauer was this always the case in Java or just a new behavior due to Potel?

@adinauer
Copy link
Member Author

@cleptric it's always been that way since we introduced our first propagator 2+ years ago.

@cleptric
Copy link
Member

Are we only talking about Otel or tracing in general?

@adinauer
Copy link
Member Author

OpenTelemetry only, the rest of the SDK does check the URL where possible (not all libraries allow us to get the URL).

@cleptric
Copy link
Member

We should take tracePropagationTargets into account for our SDK OTel propagators.
E.g. JS does https://github.com/getsentry/sentry-javascript/blob/develop/packages/opentelemetry/src/propagator.ts#L131-L151.

@adinauer
Copy link
Member Author

Thanks for the clarification. Will change it in Java SDK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants