Naga shouldn't evaluate overrides unless they're used by the entry point #5885
Assignees
Labels
area: naga back-end
Outputs of naga shader conversion
naga
Shader Translator
type: bug
Something isn't working
Comments
jimblandy
added
type: bug
|
Firefox downstream tracking: bug 1953930 |
|
This is P1 for Firefox because it prevents this WebGPU Sample from running: https://webgpu.github.io/webgpu-samples/?sample=samplerParameters |
andyleiserson
added a commit
to andyleiserson/wgpu
that referenced
this issue
Apr 24, 2025
Changes the MSL and HLSL backends to support writing only a single entry point, and uses them that way in wgpu-hal. This is working towards a fix for gfx-rs#5885.
6 tasks
andyleiserson
added a commit
to andyleiserson/wgpu
that referenced
this issue
Apr 29, 2025
Changes the MSL and HLSL backends to support writing only a single entry point, and uses them that way in wgpu-hal. This is working towards a fix for gfx-rs#5885.
9 tasks
teoxoy
pushed a commit
that referenced
this issue
Apr 30, 2025
Changes the MSL and HLSL backends to support writing only a single entry point, and uses them that way in wgpu-hal. This is working towards a fix for #5885. * Increase the limit in test_stack_size
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When generating code for a
naga::Module, Naga currently evaluates every override-expression it can, regardless of whether that expression is statically used by the entry point(s) for which we are generating code. The WGSL committee's recent discussions clarified that errors should only be reported from override-expressions that are actually statically used.The text was updated successfully, but these errors were encountered: