Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publishing actions in GitHub Marketplace appears to wrongly suggest you will see an "Everything looks good!" message #35440

Open
1 task done
Tracked by #35771 ...
jsoref opened this issue Nov 26, 2024 · 6 comments
Labels
actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team needs SME This proposal needs review from a subject matter expert waiting for review Issue/PR is waiting for a writer's review

Comments

@jsoref
Copy link
Contributor

jsoref commented Nov 26, 2024

Code of Conduct

What article on docs.github.com is affected?

https://docs.github.com/en/actions/sharing-automations/creating-actions/publishing-actions-in-github-marketplace

What part(s) of the article would you like to see updated?

If the labels in your metadata file contain any problems, you will see an error message. Address them by updating your metadata file. Once complete, you will see an "Everything looks good!" message.

I'm not sure if this still happens. I tried creating a test action and while I tripped over some of the other items, I didn't see "Everything looks good!"

Additional information

No response

@jsoref jsoref added the content This issue or pull request belongs to the Docs Content team label Nov 26, 2024
@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Nov 26, 2024
@nguyenalex836 nguyenalex836 added actions This issue or pull request should be reviewed by the docs actions team waiting for review Issue/PR is waiting for a writer's review needs SME This proposal needs review from a subject matter expert and removed triage Do not begin working on this issue until triaged by the team labels Nov 26, 2024
@nguyenalex836
Copy link
Contributor

@jsoref Thank you for raising this issue! I'll get this triaged for review ✨ Our team will provide feedback regarding the best next steps for this issue - thanks for your patience! 💛

Copy link
Contributor

Thanks for opening an issue! We've triaged this issue for technical review by a subject matter expert 👀

Copy link
Contributor

This is a gentle bump for the docs team that this issue is waiting for technical review.

@github-actions github-actions bot added the SME stale The request for an SME has staled label Dec 25, 2024
@nguyenalex836 nguyenalex836 removed the SME stale The request for an SME has staled label Dec 26, 2024
Copy link
Contributor

This is a gentle bump for the docs team that this issue is waiting for technical review.

@github-actions github-actions bot added the SME stale The request for an SME has staled label Jan 24, 2025
@nguyenalex836 nguyenalex836 removed the SME stale The request for an SME has staled label Jan 24, 2025
@subatoi
Copy link
Contributor

subatoi commented Jan 31, 2025

Hi @jsoref, I've heard back from the Marketplace team and they've told us that nothing's wrong with the docs–if you remember what other items you tripped up on that you noted in this issue's description, I can pass the feedback to them. I realise that doesn't explain what happened in your case, but I'm unable to get a better outcome at this point.

For now I think the best course of action will be to close this issue, but certainly if you or anyone else spots the same discrepancy, feel free to add a new comment.

I'll leave this open to give you a chance to reply at your convenience—many thanks as ever for your help and support with our docs.

@jsoref
Copy link
Contributor Author

jsoref commented Jan 31, 2025

@subatoi I just published https://github.com/marketplace/actions/musical-spoon-congenial-pancake

I started with a number of mistakes in the publication process (no tag, no title). when I finished it took me to https://github.com/check-spelling-sandbox/musical-spoon-congenial-pancake/releases/tag/v0.0.0 at no point did I see "Everything looks good!"

Image

Image

If you can show a video with "Everything looks good!", I'd accept the claim that the documentation is correct, otherwise, I firmly believe it's wrong as I have been unable to get it to say "Everything looks good!".

I did in publishing https://github.com/marketplace/actions/musical-spoon-congenial-pancake v0.0.1 temporarily invalidate the action.yml (by removing the mandatory name: field).

Beyond that, the text talks about labels:

If the labels in your metadata file contain any problems, you will see an error message.

But, nowhere in Metadata syntax for GitHub Actions does the word labels appear... So, even that seems likely to be incorrect.

I had to go a couple of rounds trying to decide which things to try to corrupt to prove that this screen never happens (I settled on the missing name: field, and not having a tag in the publishing screen).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team needs SME This proposal needs review from a subject matter expert waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Development

No branches or pull requests

3 participants