You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The id field on the pull-request-review schema is an int but values over 2147483647 are returned via the api
This is causing runtime issues for the generated SDK as noted in this issue octokit/dotnet-sdk#106
here's the object definition from the dereferenced OpenAPI Spec
"/repos/{owner}/{repo}/pulls/{pull_number}/reviews":
get:
summary: List reviews for a pull requestdescription: |- Lists all reviews for a specified pull request. The list of reviews returns in chronological order. This endpoint supports the following custom media types. For more information, see "[Media types](https://docs.github.com/rest/using-the-rest-api/getting-started-with-the-rest-api#media-types)." - **`application/vnd.github-commitcomment.raw+json`**: Returns the raw markdown body. Response will include `body`. This is the default if you do not pass any specific media type. - **`application/vnd.github-commitcomment.text+json`**: Returns a text only representation of the markdown body. Response will include `body_text`. - **`application/vnd.github-commitcomment.html+json`**: Returns HTML rendered from the body's markdown. Response will include `body_html`. - **`application/vnd.github-commitcomment.full+json`**: Returns raw, text, and HTML representations. Response will include `body`, `body_text`, and `body_html`.tags:
- pullsoperationId: pulls/list-reviewsexternalDocs:
description: API method documentationurl: https://docs.github.com/rest/pulls/reviews#list-reviews-for-a-pull-requestparameters:
- *229- *230- *470- *18- *20responses:
'200':
description: The list of reviews returns in chronological order.content:
application/json:
schema:
type: arrayitems: &473title: Pull Request Reviewdescription: Pull Request Reviews are reviews on pull requests.type: objectproperties:
id:
description: Unique identifier of the reviewexample: 42type: integernode_id:
type: stringexample: MDE3OlB1bGxSZXF1ZXN0UmV2aWV3ODA=
Expected
The id property should specify the int64 format
id:
description: Unique identifier of the reviewexample: 42type: integerformat: int64
Reproduction Steps
curl --request GET --url 'https://api.github.com/repos/microsoft/kiota/pulls/4602/reviews?page=2'
Thank you for reporting! This was fixed yesterday (I think it was part of #3811, though the web UI is reluctant to show me) and validated in downstream SDK generation.
Schema Inaccuracy
The id field on the pull-request-review schema is an int but values over 2147483647 are returned via the api
This is causing runtime issues for the generated SDK as noted in this issue octokit/dotnet-sdk#106
here's the object definition from the dereferenced OpenAPI Spec
Expected
The id property should specify the int64 format
Reproduction Steps
yeilds this JSON
Here we can see that the id will cause an overflow of a 32-bit integer
The text was updated successfully, but these errors were encountered: