Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Google Cloud doesn't allow "." in instance names, provides an interface
to override the default naming convention for the "scale" command.
There are a few things to still decide on:
Google has a few different ways to authenticate, so still need to figure out which ones to support:
For SSH keys, Google doesn't seem to do "named" keys like the others. You can either upload a global SSH key that is automatically added to all instances, or upload the key data when setting up an instance.
I'm also trying to decide on the default for the disk "autodelete" setting. The Google default is "false" so the disks would need deleted manually. Maybe this should be an environment setting.