Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

underdash: Application and Classes #363

Closed
taion opened this issue Jun 27, 2015 · 3 comments
Closed

underdash: Application and Classes #363

taion opened this issue Jun 27, 2015 · 3 comments
Milestone

Comments

@taion
Copy link
Collaborator

taion commented Jun 27, 2015

ref #337

Sort of a grab bag.

  • Alt doesn't require a specific base class for any of its objects. Relevant behaviors are set up at registration time.
  • Marty has base classes for everything. Registration essentially just registers the object to the app.

See: #344

Gitter discussion from https://gitter.im/goatslacker/alt?at=558b7039ad7e376201fe886b through https://gitter.im/goatslacker/alt?at=558ba568e6702c3a57647179.

@taion
Copy link
Collaborator Author

taion commented Jun 28, 2015

One migration-related thought - what if we deprecate e.g. #createActions() in favor of something like #register()? This would make it possible to put the Alt compat wrappers in the deprecated functions to avoid breaking existing users and allowing gradual migration.

@taion taion added underdash and removed underdash labels Jun 28, 2015
@taion taion added this to the underdash milestone Jun 28, 2015
@goatslacker
Copy link
Owner

I don't have an opinion here. Registration is essential if you're going the instance approach, if you're doing singletons then the registration happens whenever you import the store or action.

I think deprecating createStore, createActions in favor of a register decorator/function call makes sense.

@taion
Copy link
Collaborator Author

taion commented Jul 15, 2017

I think this is irrelevant now.

@taion taion closed this as completed Jul 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants