Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash if delete addon after download #102288

Closed
FourGames opened this issue Feb 1, 2025 · 4 comments
Closed

Crash if delete addon after download #102288

FourGames opened this issue Feb 1, 2025 · 4 comments

Comments

@FourGames
Copy link

Tested versions

Godot v4.4.beta2

System information

Godot v4.4.beta2 - Windows 11 (build 22631) - Multi-window, 3 monitors - Vulkan (Forward+) - dedicated NVIDIA GeForce GTX 1070 (NVIDIA; 32.0.15.6614) - AMD Ryzen 5 3600 6-Core Processor (12 threads)

Issue description

Crash if delete addons after download, tested with multiple addons all the same.

Steps to reproduce

20250201-1449-23.1185138.mp4

Minimal reproduction project (MRP)

n/a

@Hilderin
Copy link
Contributor

Hilderin commented Feb 1, 2025

Pretty sure that's a side effect of #99844

When the addon is imported, the progress bar for the reimportation is inside the success dialog:

Image

When the dialog is closed, the get_window of the progress dialog returns null propably because it was destroyed. That causes the get_last_exclusive_window to return null.

Image

cc @KoBeWi

@KoBeWi
Copy link
Member

KoBeWi commented Feb 1, 2025

#102237 will likely fix it.

@AThousandShips AThousandShips added this to the 4.4 milestone Feb 2, 2025
@AThousandShips AThousandShips moved this from Unassessed to Release Blocker in 4.x Release Blockers Feb 2, 2025
@Maran23
Copy link
Contributor

Maran23 commented Feb 6, 2025

We should check if this is fixed by #102237, so we may close this ticket.

@Hilderin
Copy link
Contributor

Hilderin commented Feb 6, 2025

Tested with a build from master and I'm not able to reproduce the error.
I still the progress bar inside the confirmation popup but it does not crash anymore.

Image

@Hilderin Hilderin closed this as completed Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Release Blocker
Development

No branches or pull requests

5 participants