Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include example for custom/caching transport and oauth usage #988

Closed
tmc opened this issue Aug 31, 2018 · 14 comments
Closed

Include example for custom/caching transport and oauth usage #988

tmc opened this issue Aug 31, 2018 · 14 comments
Labels
challenging This issue is for experienced Go developers only, please. enhancement

Comments

@tmc
Copy link

tmc commented Aug 31, 2018

Providing a custom Transport with oauth2 is a little verbose and having an example usage of it here would be useful:

ctx := context.WithValue(oauth2.NoContext, oauth2.HTTPClient, client)

@urohit011
Copy link
Contributor

I would like to take it.

@shubhodeep9
Copy link

@gmlewis @tmc Is this issue still open for working?

@gmlewis
Copy link
Collaborator

gmlewis commented Dec 26, 2018

@urohit011 - do you still want to work on this, or shall we assign it to @shubhodeep9 ?

@shubhodeep9 - let's give @urohit011 a couple days to answer and if we have still not heard back, we'll assign it to you.

@shubhodeep9
Copy link

@gmlewis Happy New Year, would like to know the status if I can work on this?

@gmlewis
Copy link
Collaborator

gmlewis commented Jan 2, 2019

Happy New Year to you too, @shubhodeep9!
Sure, I think it is safe for you to take this issue.

I'm unable to send you an invite, but by this comment, please will see that you are assigned to this issue.

@IamRaviTejaG
Copy link

@gmlewis Can you assign me the issue in case this issue is available.

@gmlewis
Copy link
Collaborator

gmlewis commented Jan 13, 2019

@shubhodeep9 - are you still working on this issue? If not, @ImRaviTejaG would like to take it.

@ImRaviTejaG - let's give @shubhodeep9 a couple days to respond before we switch it to you.
Thanks.

@shubhodeep9
Copy link

@gmlewis sorry, been caught up with something. Give me 3 days, if not done, then I will surely convey to assign it to someone else. Thank you

@IamRaviTejaG
Copy link

IamRaviTejaG commented Jan 13, 2019

@gmlewis Sure! @shubhodeep9 Thanks for the quick revert. I await your PR. 😄

@shubhodeep9
Copy link

@gmlewis apologies for blocking time, you may assign it to @ImRaviTejaG

Thanks

@gmlewis
Copy link
Collaborator

gmlewis commented Jan 16, 2019

No problem, @shubhodeep9.

@ImRaviTejaG - this issue is now assigned to you.

@IamRaviTejaG
Copy link

@gmlewis Thanks! Please give me a heads up on where to get started so that I can get it done quickly.

@gmlewis
Copy link
Collaborator

gmlewis commented Jan 16, 2019

Hi @ImRaviTejaG - I removed the "good first issue" tag, as maybe that is not appropriate for this issue.

Ideally, someone who has experience using oauth2 (and can provide a simple example) would take on this issue. If you don't feel that this is you, then feel free to decline and we will leave this open for someone else to provide.

Thanks for your understanding.

@gmlewis gmlewis added the challenging This issue is for experienced Go developers only, please. label Aug 6, 2021
@gmlewis
Copy link
Collaborator

gmlewis commented Mar 17, 2025

I believe this issue was resolved by #3180.
Closing.

@gmlewis gmlewis closed this as completed Mar 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
challenging This issue is for experienced Go developers only, please. enhancement
Projects
None yet
Development

No branches or pull requests

5 participants