Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not working in snappy compressions #609

Closed
topilski opened this issue Aug 3, 2018 · 5 comments
Closed

Not working in snappy compressions #609

topilski opened this issue Aug 3, 2018 · 5 comments

Comments

@topilski
Copy link

topilski commented Aug 3, 2018

Hello, i think now master branch not working with snappy compressed data, can you recheck it?

@topilski
Copy link
Author

topilski commented Aug 7, 2018

Here link why i think so: fastogt/fastonosql#63

@pwnall
Copy link
Member

pwnall commented Aug 9, 2018

You probably built the project without having snappy installed. Snappy is an optional dependency and the build can succeed without it, resulting in a binary that can't compress / decompress data blocks.

@pwnall pwnall closed this as completed Aug 9, 2018
@topilski
Copy link
Author

topilski commented Aug 9, 2018

In Cmake i see you looking snappy like: check_library_exists(snappy snappy_compress "" HAVE_SNAPPY) , i built snappy from sources master branch.

On Windows i have:

-- Looking for crc32c_value in crc32c
-- Looking for crc32c_value in crc32c - not found
-- Looking for snappy_compress in snappy
-- Looking for snappy_compress in snappy - not found

On Linux i have:

-- Looking for crc32c_value in crc32c
-- Looking for crc32c_value in crc32c - not found
-- Looking for snappy_compress in snappy
-- Looking for snappy_compress in snappy - not found

On MacOSX i have:

-- Looking for crc32c_value in crc32c
-- Looking for crc32c_value in crc32c - not found
-- Looking for snappy_compress in snappy
-- Looking for snappy_compress in snappy - not found

here sources: https://github.com/fastogt/fastonosql/blob/master/build/build_env.py#L52

here stackoverflow issue: https://stackoverflow.com/questions/49620421/unable-to-compile-leveldb-with-snappy-support

@topilski
Copy link
Author

topilski commented Aug 9, 2018

Here my fix if you are interesting: fastogt@dd6e5ad

@jl0x61
Copy link
Contributor

jl0x61 commented Jan 18, 2020

I couldn't find snappy_compress in snappy.h of version 1.1.7 or 1.1.8, so I just comment check_library_exists(snappy snappy_compress "" HAVE_SNAPPY) and add SET(HAVE_SNAPPY TRUE) to CMakeLists.txt . It works well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants