Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ggp][ast] Support AST::THIS and AST::NULL as first-class constants #331

Open
miraleung opened this issue Jul 24, 2021 · 0 comments
Open

[ggp][ast] Support AST::THIS and AST::NULL as first-class constants #331

miraleung opened this issue Jul 24, 2021 · 0 comments
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@miraleung
Copy link
Contributor

Context:

gapic-generator-php/src/Generation/OneofWrapperGenerator.php

Line 202 in 30410ff

// AST::THIS gives some weird errors, so use the value directly.

@miraleung miraleung added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Jul 24, 2021
@miraleung miraleung mentioned this issue Jul 24, 2021
Merged
@yoshi-automation yoshi-automation added 🚨 This issue needs some love. and removed 🚨 This issue needs some love. labels Nov 3, 2021
@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label Jan 20, 2022
@noahdietz noahdietz removed the 🚨 This issue needs some love. label Feb 8, 2022
@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label Feb 8, 2022
@noahdietz noahdietz added priority: p3 Desirable enhancement or fix. May not be included in next release. and removed priority: p2 Moderately-important priority. Fix may not be included in next release. 🚨 This issue needs some love. labels Feb 8, 2022
@alicejli alicejli removed their assignment Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@miraleung @noahdietz @yoshi-automation @alicejli