snippet gen feature request: add UpdateMask to update samples #558
Labels
good first issue
This issue is a good place to started contributing to this repository.
priority: p3
Desirable enhancement or fix. May not be included in next release.
samples
Issues that are directly related to samples.
type: feature request
‘Nice-to-have’ improvement, new feature or different behavior or design.
Many of the
update
RPC methods require aFieldMask
in order to have an effect. This is conveyed in the samples like VideoStitcherServiceClient::updateCdnKey where the parameter is required, but in other RPCs such as LivestreamServiceClient::updateInput, it's not obvious to the user that this is required. And the effect of not knowing this is that the RPC call has no effect (no fields are updated), even though the request is successful.When the
updateMask
parameter is marked optional, it would be more useful if we included creating theupdateMask
as part of the sample.This may be addressed once we release support in PHP for
method_signature
annotations (see https://google.aip.dev/134)The text was updated successfully, but these errors were encountered: