Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usage of non standard JSON schema #313

Open
amirh opened this issue Mar 14, 2025 · 0 comments
Open

Usage of non standard JSON schema #313

amirh opened this issue Mar 14, 2025 · 0 comments
Assignees
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: question Request for information or clarification. Not an issue.

Comments

@amirh
Copy link
Collaborator

amirh commented Mar 14, 2025

Splitting off #293

Image

  • why are you not using standard JSON schema? this json schema-like but not quite json schema because the type fields are uppercased enums makes zero sense to me and is really bad for interop with other tools. json schema is a standard for a reason – please consider using it. if you have to support only a subset of it, that's fine, but slightly changing the spec is really annoying imho.
  • both typing and execution-wise, if I'm using AI tools and JSON schema definitions generated from other places, this won't "just work". it'll require a weird transformation step.
  • same for not supporting the additionalProperties attribute
  • i'm not able to, for instance, use the stdlib of tools from https://github.com/transitive-bullshit/agentic without
  • example of me trying unsuccessfully to get this to work: https://github.com/transitive-bullshit/google-ai-test/blob/main/src/function-calling-1.ts
@amirh amirh added priority: p3 Desirable enhancement or fix. May not be included in next release. type: question Request for information or clarification. Not an issue. labels Mar 14, 2025
@yyyu-google yyyu-google self-assigned this Mar 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: question Request for information or clarification. Not an issue.
Projects
None yet
Development

No branches or pull requests

2 participants