Add description modification #316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AAJELLAL
requested changes
Dec 22, 2023
| } | ||
|
|
||
| const schema = yup.object().shape({ | ||
| [DESCRIPTION]: yup.string().nullable(), |
There was a problem hiding this comment.
The description field should not allow blank space and "" as values don't you think?
There was a problem hiding this comment.
Description is optionnal, so i think it should be allowed
| onClose(); | ||
| }; | ||
|
|
||
| const onSubmit = (data: { description: string }) => { |
There was a problem hiding this comment.
It would be better if you use useCallback.
souissimai
reviewed
Jan 4, 2024
AAJELLAL
approved these changes
Jan 4, 2024
souissimai
approved these changes
Jan 9, 2024
souissimai
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.