-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add description modification #316
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
df0b8e4
Add description modification
d56f329
review fix
216a805
Merge branch 'main' into add_description_modification
bc827da
review fix
87d38b6
fix prettier
2ce5ba4
fix prettier
f4f8d3c
fix tooltip size & text ovverflow
e1a0b03
fix description tooltip
f60feb6
remove tooltip when description is empty
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
85 changes: 85 additions & 0 deletions
85
src/components/dialogs/description-modification/description-modification-dialogue.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,85 @@ | ||
/** | ||
* Copyright (c) 2023, RTE (http://www.rte-france.com) | ||
* This Source Code Form is subject to the terms of the Mozilla Public | ||
* License, v. 2.0. If a copy of the MPL was not distributed with this | ||
* file, You can obtain one at http://mozilla.org/MPL/2.0/. | ||
*/ | ||
|
||
import { FunctionComponent, useCallback } from 'react'; | ||
import yup from '../../utils/yup-config'; | ||
import { DESCRIPTION } from '../../utils/field-constants'; | ||
import { useForm } from 'react-hook-form'; | ||
import { yupResolver } from '@hookform/resolvers/yup'; | ||
import { updateElement } from '../../../utils/rest-api'; | ||
import { TextInput, useSnackMessage } from '@gridsuite/commons-ui'; | ||
import CustomMuiDialog from '../commons/custom-mui-dialog/custom-mui-dialog'; | ||
import React from 'react'; | ||
|
||
interface IDescriptionModificationDialogue { | ||
elementUuid: string; | ||
description: string; | ||
open: boolean; | ||
onClose: () => void; | ||
} | ||
|
||
const schema = yup.object().shape({ | ||
[DESCRIPTION]: yup.string().nullable(), | ||
}); | ||
|
||
const DescriptionModificationDialogue: FunctionComponent< | ||
IDescriptionModificationDialogue | ||
> = ({ elementUuid, description, open, onClose }) => { | ||
const { snackError } = useSnackMessage(); | ||
|
||
const emptyFormData = { | ||
[DESCRIPTION]: description ?? '', | ||
}; | ||
|
||
const methods = useForm({ | ||
defaultValues: emptyFormData, | ||
resolver: yupResolver(schema), | ||
}); | ||
|
||
const { reset } = methods; | ||
|
||
const onCancel = () => { | ||
reset({ | ||
[DESCRIPTION]: '', | ||
}); | ||
onClose(); | ||
}; | ||
|
||
const onSubmit = useCallback( | ||
(data: { description: string }) => { | ||
updateElement(elementUuid, { | ||
[DESCRIPTION]: data[DESCRIPTION].trim(), | ||
}).catch((error) => { | ||
snackError({ | ||
messageTxt: error.message, | ||
headerId: 'descriptionModificationError', | ||
}); | ||
}); | ||
}, | ||
[elementUuid, snackError] | ||
); | ||
|
||
return ( | ||
<CustomMuiDialog | ||
open={open} | ||
onClose={onCancel} | ||
onSave={onSubmit} | ||
formSchema={schema} | ||
formMethods={methods} | ||
titleId={'descriptionModificationDialog'} | ||
> | ||
<TextInput | ||
name={DESCRIPTION} | ||
formProps={{ | ||
multiline: true, | ||
}} | ||
/> | ||
</CustomMuiDialog> | ||
); | ||
}; | ||
|
||
export default DescriptionModificationDialogue; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The description field should not allow blank space and "" as values don't you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description is optionnal, so i think it should be allowed